summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2024-11-25 17:10:24 +0300
committerChristian Brauner <brauner@kernel.org>2024-12-02 13:25:14 +0300
commit4fa6af563d4dcef43ae34a9bce9d1a9440f20867 (patch)
tree1d3627c674c9986818d391529c10ac3eed72631c
parent76a40086683933431660b348dbfefa80b9eaaa03 (diff)
downloadlinux-4fa6af563d4dcef43ae34a9bce9d1a9440f20867.tar.xz
nfsd: avoid pointless cred reference count bump
The code already got rid of the extra reference count from the old version of override_creds(). Link: https://lore.kernel.org/r/20241125-work-cred-v2-28-68b9d38bb5b2@kernel.org Acked-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
-rw-r--r--fs/nfsd/auth.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
index c399a5f030af..4dc327e02456 100644
--- a/fs/nfsd/auth.c
+++ b/fs/nfsd/auth.c
@@ -79,8 +79,7 @@ int nfsd_setuser(struct svc_cred *cred, struct svc_export *exp)
else
new->cap_effective = cap_raise_nfsd_set(new->cap_effective,
new->cap_permitted);
- put_cred(override_creds(get_new_cred(new)));
- put_cred(new);
+ put_cred(override_creds(new));
return 0;
oom: