diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-11-25 17:10:23 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-02 13:25:14 +0300 |
| commit | 76a40086683933431660b348dbfefa80b9eaaa03 (patch) | |
| tree | 01b758bb960254a9843048d4fd7c22e555c5d42c | |
| parent | 9e8534f5ae4f506b6fbda62add578d629c657816 (diff) | |
| download | linux-76a40086683933431660b348dbfefa80b9eaaa03.tar.xz | |
cachefiles: avoid pointless cred reference count bump
The cache holds a long-term reference to the credentials that's taken
when the cache is created and put when the cache becomes unused.
Link: https://lore.kernel.org/r/20241125-work-cred-v2-27-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/cachefiles/internal.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h index 1cfeb3b38319..7b99bd98de75 100644 --- a/fs/cachefiles/internal.h +++ b/fs/cachefiles/internal.h @@ -393,13 +393,13 @@ extern int cachefiles_determine_cache_security(struct cachefiles_cache *cache, static inline void cachefiles_begin_secure(struct cachefiles_cache *cache, const struct cred **_saved_cred) { - *_saved_cred = override_creds(get_new_cred(cache->cache_cred)); + *_saved_cred = override_creds(cache->cache_cred); } static inline void cachefiles_end_secure(struct cachefiles_cache *cache, const struct cred *saved_cred) { - put_cred(revert_creds(saved_cred)); + revert_creds(saved_cred); } /* |