diff options
| author | Qasim Ijaz <qasdev00@gmail.com> | 2025-06-06 21:49:59 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.com> | 2025-06-10 22:10:27 +0300 |
| commit | 85a720f4337f0ddf1603c8b75a8f1ffbbe022ef9 (patch) | |
| tree | a7a39af1eda16dff26cc3b8b3d02f8a97e9e6a98 | |
| parent | 1a19ae437ca5d5c7d9ec2678946fb339b1c706bf (diff) | |
| download | linux-85a720f4337f0ddf1603c8b75a8f1ffbbe022ef9.tar.xz | |
HID: wacom: fix kobject reference count leak
When sysfs_create_files() fails in wacom_initialize_remotes() the error
is returned and the cleanup action will not have been registered yet.
As a result the kobject???s refcount is never dropped, so the
kobject can never be freed leading to a reference leak.
Fix this by calling kobject_put() before returning.
Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/wacom_sys.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 58cbd43a37e9..1257131b1e34 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2059,6 +2059,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); kfifo_free(&remote->remote_fifo); + kobject_put(remote->remote_dir); return error; } |