diff options
| author | Qasim Ijaz <qasdev00@gmail.com> | 2025-06-06 21:49:58 +0300 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.com> | 2025-06-10 22:10:27 +0300 |
| commit | 1a19ae437ca5d5c7d9ec2678946fb339b1c706bf (patch) | |
| tree | 7df27b3342cc71e877eb290a590af6addcafe15a | |
| parent | 5ae416c5b1e2e816aee7b3fc8347adf70afabb4c (diff) | |
| download | linux-1a19ae437ca5d5c7d9ec2678946fb339b1c706bf.tar.xz | |
HID: wacom: fix memory leak on sysfs attribute creation failure
When sysfs_create_files() fails during wacom_initialize_remotes() the
fifo buffer is not freed leading to a memory leak.
Fix this by calling kfifo_free() before returning.
Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/wacom_sys.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ec5282bc69d6..58cbd43a37e9 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2058,6 +2058,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) if (error) { hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); + kfifo_free(&remote->remote_fifo); return error; } |