diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-01-30 20:13:45 +0300 |
|---|---|---|
| committer | Conor Dooley <conor.dooley@microchip.com> | 2026-02-06 22:54:27 +0300 |
| commit | 3c85234b979af71cb9db5eb976ea08a468415767 (patch) | |
| tree | 1bfaac232086a319db73ee643d14b72ea1d62cd2 | |
| parent | ff4b6bf7eef4f5b921eed78f2816abcc55bcdd68 (diff) | |
| download | linux-3c85234b979af71cb9db5eb976ea08a468415767.tar.xz | |
cache: starfive: fix device node leak in starlink_cache_init()
of_find_matching_node() returns a device_node with refcount incremented.
Use __free(device_node) attribute to automatically call of_node_put()
when the variable goes out of scope, preventing the refcount leak.
Fixes: cabff60ca77d ("cache: Add StarFive StarLink cache management")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
| -rw-r--r-- | drivers/cache/starfive_starlink_cache.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/cache/starfive_starlink_cache.c b/drivers/cache/starfive_starlink_cache.c index 24c7d078ca22..3a25d2d7c70c 100644 --- a/drivers/cache/starfive_starlink_cache.c +++ b/drivers/cache/starfive_starlink_cache.c @@ -102,11 +102,11 @@ static const struct of_device_id starlink_cache_ids[] = { static int __init starlink_cache_init(void) { - struct device_node *np; u32 block_size; int ret; - np = of_find_matching_node(NULL, starlink_cache_ids); + struct device_node *np __free(device_node) = + of_find_matching_node(NULL, starlink_cache_ids); if (!of_device_is_available(np)) return -ENODEV; |