| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
the direct variable update in PasswordSmmInit fails with an
EFI_NOT_AVAILABLE_YET error. This occurs because the initial NV
variable write relies on the EFI_VARIABLE_WRITE_ARCH_PROTOCOL, which
has not yet been installed during the early DXE/SMM init phase.
|
|
Delete ManageabilityPkg as it is already migrated to
edk2 repo (https://github.com/tianocore/edk2/pull/12162),
at commit ID: ef745f258c03085973e5eeeba4452adedbc0ac22.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
Follow-up to the 4-bit keyboard BMP conversion in PR #969 for the
remaining two icon assets in VirtualKeyboardDxe.
SimpleIcon.bmp uses only 2 unique colors (pure black/white);
convert to 1-bit paletted BMP for a byte-level lossless reduction.
FullIcon.bmp uses 198 unique colors; convert to 8-bit paletted BMP
for a byte-level lossless reduction (198 < 256 palette entries,
no quantization required).
EDK2 BaseBmpSupportLib already supports 1-bit and 8-bit uncompressed
BMP (TranslateBmpToGopBlt handles both BitsPerPixel values).
Per-file size reduction (24-bit -> target):
SimpleIcon.bmp: 2814 -> 182 (1-bit)
FullIcon.bmp: 5454 -> 2878 (8-bit)
Pixel dimensions and visual layout are unchanged.
Signed-off-by: James Lu <james.lu@intel.com>
|
|
edk2 is moving ArmLib to MdePkg. Update DSCs accordingly.
Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
[ardb: add missed instance in N1SdpPlatform.dsc]
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
|
|
Check if the pointer ResponseDataSize is valid or not
before using it.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
ManageabilityPkg.dsc is used to build the entire manageability
package. Manageability.dsc.inc is included in ManageabilityPkg.dsc
to build all manageability drivers. Manageability.dsc.inc
can be also included in platform DSC file to enable the
specific manageability driver according to the platform
manageability package PCD settings.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the ECC errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the CodeQL errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the MSVC build errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the component section check errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the DEBUG Macros check errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the invalid package path check errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the Spell checks errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the Uncrustify checks errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
This is the prerequisite of migrate Manageability package
from edk2-platforms to edk2 repository.
Fix the LibraryClass checks errors.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
Update package DEC file header to give a clear
descriptions of the usage of this ManageabilityPkg.
Signed-off-by: Abner Chang <abner.chang@amd.com>
|
|
The multiplication of Extent.ee_len (UINT16) and Partition->BlockSize (UINT32)
was performed using 32-bit arithmetic, which can overflow before being
assigned to the 64-bit ExtentLengthBytes variable. This overflow can lead
to an incorrect ExtentMayRead value and subsequent out-of-bounds disk reads.
Example:
If Partition->BlockSize is 0x200000 (2MB) and Extent.ee_len is 0x800,
the result of 0x200000 * 0x800 is 0x100000000. In 32-bit arithmetic, this
overflows to 0x0. Consequently, ExtentLengthBytes becomes 0, causing
ExtentMayRead to be calculated incorrectly (e.g., underflowing when
subtracting ExtentOffset) and potentially leading to an out-of-bounds
read in Ext4ReadDiskIo.
Casting Extent.ee_len to UINT64 ensures the multiplication is performed
using 64-bit arithmetic.
Signed-off-by: Phineas Su <pohaosu@google.com>
|
|
Convert the three VirtualKeyboardDxe keyboard bitmap assets from
24-bit BMP to 4-bit paletted BMP. Each bitmap uses fewer than 16
unique colors after median-cut quantization, so the 16-color palette
is sufficient. Pixel dimensions and visual layout are unchanged.
EDK2 BaseBmpSupportLib already supports 4-bit uncompressed BMP
(TranslateBmpToGopBlt handles BitsPerPixel==4).
Per-file size reduction (24-bit -> 4-bit):
CapitalLetterKeyboard.bmp: 330454 -> 55318
DigitKeyboard.bmp: 330454 -> 55318
SimpleKeyboard.bmp: 30054 -> 5318
Signed-off-by: James Lu <james.lu@intel.com>
|
|
If the call to IpmiSubmitCommand in IpmiGetSystemUuid succeeds
but a UUID wasn't able to be retrieved, make sure we return an
error code instead of EFI_SUCCESS.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
|
|
Added read and write support for the IPMI boot initiator mailbox.
Signed-off-by: Brit Chesley <brit.chesley@amd.com>
|
|
Initializing the Variable to 'NULL'
for resolving MSVC Build error.
Signed-off-by: Uyyala, RavitejaX <ravitejax.uyyala@intel.com>
|
|
Included additional checks for stronger password.
Signed-off-by: Uyyala, RavitejaX <ravitejax.uyyala@intel.com>
|
|
Validated on Loongson 3A6000-HV-7A2000-1w-V0.1-EVB evaluation board.
Signed-off-by: Ariadne Conill <ariadne@ariadne.space>
|
|
Iso639Language is not used anywhere in the code, so GCC flags it as an
unused variable.
Signed-off-by: Ariadne Conill <ariadne@ariadne.space>
|
|
Use RngLib to get the Random number instead of passing
seed value is NULL and seed size is zero.
Signed-off-by: Kilumu, VenkataX Sai Mahesh <venkatax.sai.mahesh.kilumu@intel.com>
|
|
Clearing password at EXIT in both cases SMM_PASSWORD_FUNCTION_SET_PASSWORD
and SMM_PASSWORD_FUNCTION_VERIFY_PASSWORD
Signed-off-by: Patel, Azhar ImtiyazX <azhar.imtiyazx.patel@intel.com>
|
|
SmmPasswordHandler returns EFI_SUCCESS even when the CommBufferSize
is less than the expected header size.
Change the return statement to return an appropriate error code
EFI_INVALID_PARAMETER instead of EFI_SUCCESS.
Signed-off-by: Reji, RencyX <rencyx.reji@intel.com>
|
|
KeyLibGenerateSalt function fails to check the return values of
RandomSeed and RandomBytes function calls. Also SavePasswordToVariable
fails to check return value from KeyLibGenerateSalt.
Added error handling code to check the return values of RandomSeed,
RandomBytes functions and KeyLibGenerateSalt in SavePasswordToVariable.
Signed-off-by: Reji, RencyX <rencyx.reji@intel.com>
|
|
Add missing EFIAPI to MMBI IPMI infrastructure functions to bypass GCC build errors.
Signed-off-by: Darren Dong <darren.dong@intel.com>
|
|
Add missing EFIAPI in implementation of UEFI event
notification functions.
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
|
|
edk2 is removing support for ARM32, so drop all
ARM32 code from edk2-platforms. This does not
change code copied from edk2 as-is.
Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
|
|
gEfiUnicodeCollationProtocolGuid was deprecated in favor of
a newer version gEfiUnicodeCollation2ProtocolGuid which
provides improved language support and better extensibility.
It was officially removed from UEFI specifications
2.10A and 2.11 and should no longer be used in
current implementations.
Cc: Sachin Ganesh <sachinganesh@ami.com>
Signed-off-by: Gowtham M <gowthamm@ami.com>
|
|
When register a root SMI handler, it is expected to use windows calling
convention for the SMI handler. This patch adds missing EFIAPI for the
SMI handler SmmSwDispatcher to avoid potential issue from Linux build.
Signed-off-by: Guo Dong <guo.dong@intel.com>
|
|
The files added under ManageabilityTransportKcsLib have been cloned from
ManageabilityTransportKcsLib/Dxe because this library can be used in both
PEI and DXE.
The original source files under the /Dxe and /Common folders will be
removed, and DxeManageabilityTransportKcs.inf will be kept for
backwards compatibility.
Signed-off-by: Cassandra Lam <Cassandra.Lam@amd.com>
|
|
When NETWORK_ENABLE is TRUE and NETWORK_ALLOW_HTTP_CONNECTIONS is TRUE,
NetworkPkg/NetworkFixedPcds.dsc.inc specifies
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections as TRUE.
But the PCD is set under [PcdsFixedAtBuild] section.
The build.py will complain the following error:
Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in
DSC is not declared in DEC files referenced
in INF files in FDF. Arch: ['IA32']
The commit fixes the failure by only setting the PCD in the
[PcdsFixedAtBuild.$(DXE_ARCH)] section.
Signed-off-by: Ray Ni <ray.ni@intel.com>
|
|
The NetworkPcds.dsc.inc include file have been broken out into 2 separate
files: NetworkFixedPcds.dsc.inc and NetworkDynamicPcds.dsc.inc
Fix NetworkFeaturePkg so it includes the correct paths.
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
|
|
MemoryDiscovered
Description:
Currently, a page fault (PF#) is observed when accessing the PEI_IPMI_TRANSPORT_PPI in the post-memory phase.
The cause of this problem is that the PPI does not migrated from temporary RAM to permanent RAM.
Solution:
Register a memory shadow handler in the PeiGenericIpmi PEIM that performs pointer fixes for PEI_IPMI_TRANSPORT_PPI after MemoryDiscovered.
Signed-off-by: Ning Feng <ning.feng@intel.com>
|
|
This adds recent PCDs for IPMI Serial for IpmiProtocol PEI and SMM to
fix the compilation error.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
|
|
This introduces serial protocol in IPMI driver.
Signed-off-by: John Chung <john.chung@arm.com>
|
|
This introduces ManageabilityTransportSerial in manageability help
library.
Signed-off-by: John Chung <john.chung@arm.com>
|
|
ManageabilityTransportSerialLib instance following the manageability
transport framework to support IPMI Serial protocol. Data structure
refer to Figure 14, IPMI 2.0.
Signed-off-by: John Chung <john.chung@arm.com>
|
|
The Keyboard.c driver did not include ScanCodes like F1,F2,F12,etc.
and UnicodeChars like Backspace, Tab in VK_NOTIFY NotifyList
which is why these keys were not getting registered and
not getting pushed in the KeyBuffer stack which resulted
in undefined behavior of continuous backspace and not recognizing the
relevant key push after the buffer overflow condition.
Signed-off-by: Darbin Reyes <darbin.reyes@intel.com>
|
|
The Keyboard.c driver did not include ScanCodes like F1,F2,F12,etc.
and UnicodeChars like Backspace, Tab in VK_NOTIFY NotifyList
which is why these keys were not getting registered and
not getting pushed in the KeyBuffer stack which resulted
in undefined behavior of continuous backspace and not recognizing the
relevant key push after the buffer overflow condition
Signed-off-by: Contributor Name <darbin.reyes@intel.com>
|
|
As noted in the code, it was intended to update various manually specified
instances of [Components.IA32/X64] to [Components.$(DXE_ARCH)] or
[Components.$(PEI_ARCH)] as appropriate, once macro expansion in the
Components {ARCH} value was supported.
This support was added some time ago[1], but the marked changes were never
made.
[1]: https://bugzilla.tianocore.org/show_bug.cgi?id=2308
Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
|
|
While calling IpmiBlobTransferSendIpmi(), it is expected that
there is no response data for certain command. Enhance this function
to accept NULL response data parameter.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
|
|
Add IpmiSmbiosTransferDxe to ManageabilityPkg.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
|
|
Adding support to transfer SMBIOS binary blob to the BMC by using
the IpmiBlobTransfer protocol.
Signed-off-by: Nick Ramirez <nramirez@nvidia.com>
Co-authored-by: Nickle Wang <nicklew@nvidia.com>
|
|
Add missing PCD: PcdIpmiSsifSmbusSlaveAddr.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
|
|
Add missing "EFIAPI" to fix GCC5 build failure.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
|
|
This introduces IpmiCommandLib/IpmiCommandLibPei.inf for the support of
the IPMI command library in PEI. It is consistent with the IpmiLib which
has supported separately an instance in PEI.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
|
