Age | Commit message (Collapse) | Author | Files | Lines |
|
The i18n.t method changed to i18n.global.t for vue3 support, so this
comment is no longer valid.
I found this on the Intel router and am pushing this for completeness,
but I didn't test this environment.
Tested:
Did not test
Change-Id: Ieba177977583bf05f6444466a630f4e6f83af91f
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
Configure sass in the vue.config.js file and remove the
import of the scss file from each page. The styles are
handled by the css loaderOptions in the config file.
Every component and page has the appropriate style applied.
The appearance adjusts to the openBmc webui in Vue 2.
Change-Id: I3773c063646185b80b7bd61d05aa80a993cbd121
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
Invalid feedback element if condition change, Helper import change
in date time page and table date filter global component.
Change-Id: I1f01943229b78d4dff36f3905fe3781ba696d528
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
For required, invalid format, minlength, maxlength, date, pattern
validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92426ebf77c9c
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
While add a file in the form file vuelidate error occurs and global
component form file not return a file, by emit the $event in form file
fix the issue.
Change-Id: Icbeddc7a3faa262f12e85268206ae70950f37905
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
While navigating to the pages i18n, vuelidate, and filters errors
occurred. i18n, and vuelidate code changes in each page adapted to
vue3. Filter global function for date and time format implemented
in the main.js file and those files which as called the filter
functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
1. Configuration of i18n legacy as false.
2. Translation function t is called using the useI18n.
3. Used the i18n.global.t() function from i18n instead of this.$t()
4. Event bus error that occurred during logout.
5. Implemented vue-router 4.4.0 and vuex upgrade to 4.1.0
Change-Id: I9464d82c76dcc1445ce271983ea3ab9d7b03d265
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
Start the process of porting everything to Vue 3. I have most things
working. npm run-scripts build works, npm install works. prettier
passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the
following design decisions:
1. Vue is put in compat 2 mode, which allows most of the components to
work as-is.
2. Bootstrap v4 is used along with bootstrap-vue to keep our components
working.
3. Minor changes are made to load the latest versions of vue-router,
vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean
up the broken things one patchset at a time. The things that need to
happen are:
1. Get remaining features working again. This primiarily is vue-i18n
for mixins, and non vue components. This likely needs to be done by
not pulling in i18n into the non vue components, then using the .Vue
files to do the internationalization in the component context, NOT in
the mixin context. Alternatively, we could drop MixIns alltogether.
2. Get custom styles working again. Previously, we used some path
hackery in vue.config.js to optionally pre-load styles. This stops
working now that we're required to @import our modules. Likely we
need some rearangement of the paths such that custom styles are a
complete replacement (possibly importing the original) rather than
additive with overrides. That's a guess, but I don't really see
anyone else doing customization the way we've defined it here.
3. Bootstrap 5 no longer requires ANY custom vue modules, as it has
dropped the jquery dependency. We won't be able to pull in bootstrap
5 all at once, so pull in bootstrap 5 under an alias, like
"bootstrap5" that we can optionally import 5 or 4.
4. One at a time, start porting components over to Vue3 syntax and
bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I
commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/
[2] https://vue-i18n.intlify.dev/guide/migration/vue3
[3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
In the FormFile component, break a long file name into
multiple lines using the word-break CSS property. This
ensures that long file names are properly displayed
within their container without causing overflow issues.
Fixes #121
The word-break property will allow the text to wrap onto
the next line at any character, maintaining the layout
integrity and improving the user interface.
Change-Id: Id534dd4e8f7737a60483272f2fdd70deb7a8a002
Signed-off-by: Farah Rasheed <Farah.Rasheed1@dell.com>
|
|
All changes should be whitespace, and were done using npm run-script
lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
There is no validation handle before checking the page title name
from the router. Which causes the pre-commit script to through error.
This patch set will handle this scenario and fix the break.
Change-Id: I5aed3bfeba643c2eb2b2753bf8f6d984b5100361
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Log in and log out of the application, change the language, and login
to the application. The heading and title are in the previous language
translation is handled in the router, and the languages are selected
after the router has rendered.The page title and heading translation
are handled after the language is selected.
Change-Id: Iba42fe3a535fe0b402f551c3f43e19d5ff12181d
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
The design has been updated to hide the download button when the
key 'AdditionalDataURI' is not present in the redfish API response.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: If78968ad72e62348b4b81967a3b61c2af53fa020
|
|
This page will be included in the Health section of the primary
navigation. The user will be able to export and download POST code
logs.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I26cf1e01bfdfcf298f24f2c7dd9633ab7d31f1b5
|
|
This will increase readability of filter menu options, by preventing
the wrapping up of long options/labels.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I75199b7608b5aeed067530e374e45750e26bb6eb
|
|
- Renames SetFocusMixin to JumpLinkMixin to better describe what the
mixin is for: jump links like quick links and skip to main content
- Adds scrollToOffset method to JumpLinkMixin methods to scroll to
selected page elements
- Scroll offset is required to show table header below the nav header
- Setting focus is required for accessibility
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I500a2d70727c5a78aeae4a6193ba22a38e4f0b6f
|
|
Displays resolved or unresolved status, adds ability to filter
by resolved or unresolved, and adds ability to resolve or
unresolve one or more logs.
Move event type table field to expanded row.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ie5761753a7660a714f98c238d8d89aa018719dcf
|
|
Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: I54ddce13b1fc02138f42141c636453f499d35b96
|
|
Problem:
When a user uses the skip link anchor to skip the navigation, the
route was being changed to /#main-content. This route does not
exist. If a user were to manually refresh the page, it would
return a 404. This link is critical to meet accessibility
guidelines and is needed by users that navigate with a keyboard.
The challenge is that we need to mirror a full page refresh on all
route changes, so we set focus on the app-header element on each route
change. When we click the skip to navigation link, there should not be
a route change. All we need is to set focus on the <main> element so
that the user can tab to the first tabbable element in the main content
section.
Solution:
- Use a native <a> element with an attached click event handler
- Prevent the default action of adding the hash to the URL
- Create a global mixin to reuse for route changes and skip link
activation
- Emit an event that can be listened for to call the global mixin
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I4c2301b02f608eeb376ed2d1bd809f3d5c1bf545
|
|
Default file upload button will be secondary, with the ability to
optionally pass 'primary' variant as a prop.
Added correct disabled button styles to the SFC scoped styles.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Idacb84a9298db0d5bce727f20842d2a1a15b7448
|
|
- Add sr-only element to icon only buttons
- Removed title from text only buttons
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: Ica57dec70401c04a9d7506306a406fe394e52113
|
|
Passing disabled prop to button and span so file upload button can
visually reflect a disabled form control state.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I78f2db521c4f4016e7e2aa92e5a56bc4f9170fe0
|
|
- Adds download row action in bmc dumps table
- Adds new rowAction download type to support <a> tag with
download attribute
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I97fd70e6a6783d4336ca1a8486cf1cd3062ebb5d
|
|
Both the datepicker and password fields have an assoicated icon. When
the input element receives focus the associated icons are hidden. This
is caused by a z-index issue and was a bug created when fixing another
bug that caused the datepicker icon from rendering above the table
batch actions toolbar.
Both bugs have been resolved with this patchset.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: If923cd5bc6a076b01efa44492f717b78fb6584ca
|
|
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I00e3fc12a58d644d0aad3c0caf4a94d2ed435109
|
|
The class name showBtn uses a camelCase naming convention and CSS
selector names use the kebab-case naming convention. The z-index
solution is not needed if we hide the element with visibility. Using
both opacity and visibility allows the transition to be elegant.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ie555f958daaadd2bc3a3777b6c2bc7d5e83a0cc5
|
|
- Changed back to top button style when its getting disappear.
- So that button should not come over the page contents.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: I0a013c2bcdd291edd9f52566130882360451a280
|
|
- Align table search, count and date components on Event Logs page.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: Id681d50f57a6fca86b8d8ba57f8e3420c1a0e56e
|
|
- Created global back to top button
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I32022613e1ba62667b46150463c8f407b0b4ff11
|
|
Span with sr-only class added to date picker button
to implicity add label.
The bootstrap vue datepicker component does not have
an accessibility prop for the button inside the
datepicker wrapper.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I6fd3e55b865343769d6c0a179ae4c5d8c1038ffb
|
|
Updates to the event values passed by BootstrapVue checkbox
components required changes to the custom component.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic6b1f3c22ff4c056b11a572777fc2f589f121676
|
|
- Now only add file button will be visible.
- And selected file name will come down to the button.
- Changed form file component from custom type to plain.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: Ib59135691495c4dddfdbbae0e4228b55cdfda2a8
|
|
- Fixes button icon and text alignment
- App header buttons to be addressed separately
- Button documentation will be addressed in separate commit
- Aligns form input buttons: datepicker, clear search, and password toggle
- Moves title from icon to button for icon only buttons
- Aligns validation icon with form input buttons
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ie28d7d7dd7303ab6bf1897d1fa569e1580cc2f9d
|
|
- Modified transition class name needed for vue3.
- Add comment for vue version based classes.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: I3578ca7c45e71326e38888412a4f36c266b005a0
|
|
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I9eea4eac3b8cacc216fc9ad1011e51622622e75f
|
|
Made updates to TableToolbar, ModalAddRoleGroup, and ModalUploadCertificate
components.
https://eslint.org/docs/rules/no-prototype-builtins
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic143cd244b288bc089a9416699d7c3d4349a500c
|
|
- 99% of changes were small syntax changes that were changed by the
lint command. There were a couple of small manual changes to meet the
property order patterns established as part of the vue:recommended
guidelines.
There are rules that were set from errors to warnings and new stories
are being opened to address those issues.
Testing:
- Successfully ran npm run serve
- Successfully ran npm run lint
- Verified functionality works as expected, e.g. success and failure use cases
- Resolved any JavaScript errors thrown to the console
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ie082f31c73ccbe8a60afa8f88a9ef6dbf33d9fd2
|
|
In Firefox there was an no unsafe eval error which was caused when
users had the vue dev tools extenstion installed and enabled. The other
issue was the loading of a resrouce at inline (style-src) which was
caused by the SVG icons coming from the Carbon icons vue library.
- Updated the Carbon icons to the latest version to resolve
the CSP issue.
- Remove chainwebpack option only used for prefecth as this is not
needed. Originally this was an issue when using code splitting.
Changing how we import views for routes and creating a single bundle
removes the need for this option.
- Update how fill color is applied to StatusIcon component. The Carbon
icons update results in adding the fill property to the svg container
does not cascade resulting in all icons rendering as their default
fill color.
GitHub Issue: https://github.com/openbmc/webui-vue/issues/32
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I4846f80c993c129d5e88fceda13d53fab51d7c8a
|
|
- Add '@/' instead of '../../../'
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: Ida1dc26f2bd62f38914a74b729ee8fd143c360ac
|
|
- Current out of the box bootstrap did not meet
IBM style guide
- Custom gradient and animation added to loading bar
to indicate progress
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I9d12c1709e7e344545a7ecfd211db0507fd40794
|
|
Details: https://github.com/openbmc/webui-vue/issues/38
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I956938186fa06b9670cb716979572a3b8d6a1b6a
|
|
- Updated new style guide for Primary, Secondary and Link button variants
- Changed box-shadow style from outer to inside on focus and active state
- Updated font weight from bold to regular for normal buttons and font
weight bold for link button.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: I38ca94baa9daec3fd03b830fc7b6d676fcce15b0
|
|
- For small viewports updated class to make event logs filter
responsive.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: I95ff82c0b4765815f70467b5ca748dcc3043d35d
|
|
- Added intial application load document title update with
created hook
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I73d18ed4a56bd04601fa7382c2d6c2ec504b03f5
|
|
- Adds ability to quickly clear a table input search field
- Uses similar styling to password toggle icon and datepicker
- Button style to be addressed in separate commit to match
style guide
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I18f2e01c28c00c7e7b2ad1af924070241caf36a5
|
|
-The total number of items and the filtered items will be shown in the
EventLogs, Sensors and HardwareStatus table.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I0ee6410bf675038a350a71a02ec076f9e8baf004
|
|
- Title attribute allows action text to be displayed on hover
- Carets in hardware status table will be addressed in a separate
commit as part of Hardware status accessibility updates
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I58a85b6d244d1125f0b43c22d0bb456a36815097
|
|
- Increase the global margin bottom size to 4rem for the page section.
- Kept same size for responsive sizes.
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: I155006a0ea9a7f6fd947d6daaea4510cadf641db
|
|
Add Intel fonts, colours
Signed-off-by: Mateusz Gapski <mateuszx.gapski@intel.com>
Change-Id: Idbfa1422f2667515efb60e24f9a84b7d77d11fcd
|
|
- Removes partial border below section heading
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ica98d171c16ebc694e0c8c816a161f94425a33b9
|