Age | Commit message (Collapse) | Author | Files | Lines |
|
The i18n.t method changed to i18n.global.t for vue3 support, so this
comment is no longer valid.
I found this on the Intel router and am pushing this for completeness,
but I didn't test this environment.
Tested:
Did not test
Change-Id: Ieba177977583bf05f6444466a630f4e6f83af91f
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
Configure sass in the vue.config.js file and remove the
import of the scss file from each page. The styles are
handled by the css loaderOptions in the config file.
Every component and page has the appropriate style applied.
The appearance adjusts to the openBmc webui in Vue 2.
Change-Id: I3773c063646185b80b7bd61d05aa80a993cbd121
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
The functionality of initiating and displaying dumps is not enabled by
default in bmcweb but it's used by at least Facebook, Fii and IBM. While
IBM has their own overview page and router code which makes it
accessible the others do not.
I do not know what the policy should be about exposing features like
that, please comment. Guess ideally webui should discover available
features on startup and add to the menu dynamically, any takers?
Change-Id: I9c85ecaba009547c69166c5cbaba62a005d75f48
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
|
|
Invalid feedback element if condition change, Helper import change
in date time page and table date filter global component.
Change-Id: I1f01943229b78d4dff36f3905fe3781ba696d528
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
For required, invalid format, minlength, maxlength, date, pattern
validation if condition change in the few components
Change-Id: Id8eebc140301e48dde833a604ca92426ebf77c9c
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
While add a file in the form file vuelidate error occurs and global
component form file not return a file, by emit the $event in form file
fix the issue.
Change-Id: Icbeddc7a3faa262f12e85268206ae70950f37905
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
While navigating to the pages i18n, vuelidate, and filters errors
occurred. i18n, and vuelidate code changes in each page adapted to
vue3. Filter global function for date and time format implemented
in the main.js file and those files which as called the filter
functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
1. Configuration of i18n legacy as false.
2. Translation function t is called using the useI18n.
3. Used the i18n.global.t() function from i18n instead of this.$t()
4. Event bus error that occurred during logout.
5. Implemented vue-router 4.4.0 and vuex upgrade to 4.1.0
Change-Id: I9464d82c76dcc1445ce271983ea3ab9d7b03d265
Signed-off-by: Surya Venkatesan <suryav@ami.com>
|
|
Start the process of porting everything to Vue 3. I have most things
working. npm run-scripts build works, npm install works. prettier
passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the
following design decisions:
1. Vue is put in compat 2 mode, which allows most of the components to
work as-is.
2. Bootstrap v4 is used along with bootstrap-vue to keep our components
working.
3. Minor changes are made to load the latest versions of vue-router,
vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean
up the broken things one patchset at a time. The things that need to
happen are:
1. Get remaining features working again. This primiarily is vue-i18n
for mixins, and non vue components. This likely needs to be done by
not pulling in i18n into the non vue components, then using the .Vue
files to do the internationalization in the component context, NOT in
the mixin context. Alternatively, we could drop MixIns alltogether.
2. Get custom styles working again. Previously, we used some path
hackery in vue.config.js to optionally pre-load styles. This stops
working now that we're required to @import our modules. Likely we
need some rearangement of the paths such that custom styles are a
complete replacement (possibly importing the original) rather than
additive with overrides. That's a guess, but I don't really see
anyone else doing customization the way we've defined it here.
3. Bootstrap 5 no longer requires ANY custom vue modules, as it has
dropped the jquery dependency. We won't be able to pull in bootstrap
5 all at once, so pull in bootstrap 5 under an alias, like
"bootstrap5" that we can optionally import 5 or 4.
4. One at a time, start porting components over to Vue3 syntax and
bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I
commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/
[2] https://vue-i18n.intlify.dev/guide/migration/vue3
[3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
In the FormFile component, break a long file name into
multiple lines using the word-break CSS property. This
ensures that long file names are properly displayed
within their container without causing overflow issues.
Fixes #121
The word-break property will allow the text to wrap onto
the next line at any character, maintaining the layout
integrity and improving the user interface.
Change-Id: Id534dd4e8f7737a60483272f2fdd70deb7a8a002
Signed-off-by: Farah Rasheed <Farah.Rasheed1@dell.com>
|
|
Ideally we wouldn't have to pull down this file on every load, and we
could just inline it. This commit implements inlining. Note, that
this requires a minor modification to the unit test, as the inline
header remains when unit tests are run. It's not clear at this time
how to make inlining plugin operate on unit tests, but it doesn't seem
terribly important.
Tested: Loading the webui no longer shows a download of logo-header
Change-Id: Iaa5be5b5a84e0ad6e1f430113f929032835c9f1c
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
All changes should be whitespace, and were done using npm run-script
lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
This page will be included in Configuration section of the primary
navigation. The user will be able to delete and add alert destination.
Change-Id: I396d19a54ea11724f2c5aec67e20ba9abff947d3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Bug description:
Before this commit KVM window wasn't being closed
after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations/kvm.
Step2. Open additional window using 'Open in new tab'.
Step3. Navigate to another page. For example, /#/operations/key-clear.
Step4. Logout. Window is still open.
Change-Id: Ife79ebca41eb4d588c0b8f4fae06135420eda155
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
In the event logs page, if the filter options are selected for both
severity and status, it displays row that falls into either of the
two categories: severity or status.
The filter options are in two categories:
severity [OK, Warning, Critical], and status [Resolved, Unresolved]
If select the filter options "Critical" on severity and "Unresolved"
on status, it shows every row whose status is "Unresolved" whether its
severity is "Ok" or "Warning", If the row data is "Critical" or
"Unresolved", it shows in the table. As per the filter selection, it
shouldn't show the row data that has "Ok" or "Warning" but the status
is "Unresolved"; it should show only the row data that is in both
"Critical" and "Unresolved".
This commit will work as follows: if different categories are
selected, that will be applied with an "and" logic, and within the
same category, it will be applied with an "or" logic.
Change-Id: I5ddf6e5ebe35c961306e68885febf6f2324ebaee
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This commit allows us to add 'exclusiveToRoles' field to
route config files, with the list of roles that can access
this resource, if needed. In this case, only Administrator
can access Virtual-Media page and SOL console, and it is blocked for other
users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
|
|
There is no validation handle before checking the page title name
from the router. Which causes the pre-commit script to through error.
This patch set will handle this scenario and fix the break.
Change-Id: I5aed3bfeba643c2eb2b2753bf8f6d984b5100361
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Log in and log out of the application, change the language, and login
to the application. The heading and title are in the previous language
translation is handled in the router, and the languages are selected
after the router has rendered.The page title and heading translation
are handled after the language is selected.
Change-Id: Iba42fe3a535fe0b402f551c3f43e19d5ff12181d
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This page will allow privileged user to clear encrypted keys.
- Only admin and CE login user will be able to see the page
- The UI will be different for both, admin and CE login user(service)
- This page is IBM only
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ic6fe3454de815629a6b2250daa99ab21f2b316c3
|
|
Eslint throws a warning to props that don't have a default value
- Added a default value to the routerKey prop.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I2d9d4abd0512eeadf27f8941a0f391979eb9a80a
|
|
The refresh button in the App header previously only re-rendered
the main mage section, this change also refreshes the app header
and main content.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: Iff7f3f14bca8ddfd815ccb1b87dd182c4bfd79ba
|
|
Mixin was renamed to reflect usage on all components,
not only tables.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ic962ba879fffa39b9f6f93446771fbf6f67915d0
|
|
This update will:
- Change the positioning of the form to be on the left
- Add the built on OpenBMC logo to the bottom right corner of the
screen
- Add the ability to include a GUI custom name using a .env variable.
If the variable is not present, the login page will not include the <h1>
section heading element.
- Remove the word "logo" from the alt attribute for the company logo
image used in the application header and on the login page.
Github story: https://github.com/openbmc/webui-vue/issues/63
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I83ac5aecff0b3858c3ab5f38ab1aaa603d59acf1
|
|
- Model type and serial number are newly added system info data on
Appheader.
- On small screens and below system information(model type, serial number and
asset tag) will be hidden.
- On large screen and below model type and serial number will be visible but
asset tag will be hidden.
- For all other screens all the system info will be visible.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: Ia844a26f658083cbd5fa9c8f3f6bea8b65ddcd11
|
|
The design has been updated to hide the download button when the
key 'AdditionalDataURI' is not present in the redfish API response.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: If78968ad72e62348b4b81967a3b61c2af53fa020
|
|
This is the sixth commit for information architecture changes and has
the following changes:
- Resource management section has been added
- Carbon icon used for resource management section is data--base--alt
- Manage power usage page from operations has been moved to
resource management
- Manage power usage page has been updated to power page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: If3feb994dbad19dd6cfb1507d976d09643c8e4d6
|
|
This is the fifth commit of the information architecture changes and
has the following changes:
- The icon for access and control has been updated
- Access and control section has been updated to security and
access section
- Security settings page has been updated to policies page and moved to
security and access section
- Client sessions page has been updated to sessions page
- Local user management page has been updated to user management page
- SSL certificates page has been updated to certificates page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ie93cee9002742ecf7d33615636f4f159f4395fc4
|
|
This is the fourth update to information architecture changes and has
the following changes:
- The configuration section is updated to settings
- The date and time settings page is updated to date and time
- The network settings page is updated to network
- The power restore policy page in operations section is moved to
settings section
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I6f5ab25f5227530be430bd39a4d9629b3bf09d8b
|
|
This is the third update to the information architecture changes and
has the following changes:
- The control section has been updated to operations
- The server led page has been removed
- The firmware page is moved to operations section
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I2e23da447890d7bee51892e1f782d5f2db6dded4
|
|
This is the second update to information architecture changes and
has the following changes:
- Health section is updated to hardware status section
- Hardware status page is updated to inventory and LEDs page
- Route for sensors page has been updated
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ia1ba3a15a243a00f59a2ec646132436eb355a999
|
|
This is the first patchset of the information architecture changes.
These changes are the result of several months of design research with
users to improve the existing information architecture (IA). More
information can we found in the Github story.
This patchset will add a Logs section and move event logs and dumps from
the Health section to the new Logs section. It will also update the icon
used for the Overview page.
Github story: https://github.com/openbmc/webui-vue/issues/56
Testing:
1. IBM build:
- Logs contained Event logs and dumps
- Both pages rendered when clicking link
2. Intel build
- Logs contained Event logs only
- Logs page rendered when clicking link
3. Tested default build
- Logs contained Event logs only
- Logs page rendered when clicking link
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I4621837202cf5ad3469d6ea460d9a5bdc79c8816
|
|
This page will be included in the Health section of the primary
navigation. The user will be able to export and download POST code
logs.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I26cf1e01bfdfcf298f24f2c7dd9633ab7d31f1b5
|
|
This will increase readability of filter menu options, by preventing
the wrapping up of long options/labels.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I75199b7608b5aeed067530e374e45750e26bb6eb
|
|
- Renames SetFocusMixin to JumpLinkMixin to better describe what the
mixin is for: jump links like quick links and skip to main content
- Adds scrollToOffset method to JumpLinkMixin methods to scroll to
selected page elements
- Scroll offset is required to show table header below the nav header
- Setting focus is required for accessibility
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I500a2d70727c5a78aeae4a6193ba22a38e4f0b6f
|
|
Displays resolved or unresolved status, adds ability to filter
by resolved or unresolved, and adds ability to resolve or
unresolve one or more logs.
Move event type table field to expanded row.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ie5761753a7660a714f98c238d8d89aa018719dcf
|
|
Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: I54ddce13b1fc02138f42141c636453f499d35b96
|
|
This patchset focuses on the global store use for server power
operations and impacts several pages in the interface.
For consistency, both in the UI and the code base, we are replacing
the term host with server. This change impacts both the user and the
developer experience. Maintaining consistency in naming allows both
developers and users to form a mental model of the overall system
and will help remove confusion when interacting with the UI and
editing the interface.
Testing:
1. Tested shutdown, power on, and reboot and verified the icons and
page sections in the site header and the server power operations page
update as expected during power operations.
2. Verified the one-time boot operations alert is displayed to the
user when changing the boot settings on the server power operations page
3 Tested factory reset and validated the correct information message
is displayed to the user with the server power off and on when
performing the factory reset functions.
4. Verified the SOL Console status icon updates correctly during
power operations.
5. Verified the alert message is displayed on the firmware update page
when the server is powered on.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I88499a746364ab80f16a8b350d550407d094e95d
|
|
-While selecting the checkbox in the table, user have to click twice to
select the data.
-The issue occured after upgrading vue-bootstrap.
-vue-bootstrap community improved the code for checkbox toggling which
causes the issue, openBmc code is been updated to support the new changes.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I0e3c3e2248c22bcf805eb6f0b73378bcf4e8ea61
|
|
This new page will be included in the Control section of the primary
navigation. The user will be able to choose between two different
reset actions.
The user can make the following calls:
- /redfish/v1/Systems/system/Bios/Actions/Bios.ResetBios
- /redfish/v1/Managers/bmc/Actions/Manager.ResetToDefaults
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I32a10dbce27a03fb84e24d7eae7c44eef9cffea5
|
|
Problem:
When a user uses the skip link anchor to skip the navigation, the
route was being changed to /#main-content. This route does not
exist. If a user were to manually refresh the page, it would
return a 404. This link is critical to meet accessibility
guidelines and is needed by users that navigate with a keyboard.
The challenge is that we need to mirror a full page refresh on all
route changes, so we set focus on the app-header element on each route
change. When we click the skip to navigation link, there should not be
a route change. All we need is to set focus on the <main> element so
that the user can tab to the first tabbable element in the main content
section.
Solution:
- Use a native <a> element with an attached click event handler
- Prevent the default action of adding the hash to the URL
- Create a global mixin to reuse for route changes and skip link
activation
- Emit an event that can be listened for to call the global mixin
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I4c2301b02f608eeb376ed2d1bd809f3d5c1bf545
|
|
Adds ability to create toasts with multi-lined body content and
options to include a timestamp and application refresh action.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I30b1da04a0e0b5f29a419950462d1ca35e207552
|
|
Default file upload button will be secondary, with the ability to
optionally pass 'primary' variant as a prop.
Added correct disabled button styles to the SFC scoped styles.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Idacb84a9298db0d5bce727f20842d2a1a15b7448
|
|
- This page will show how the system boots once power
is restored after a power disturbance.
- API used to fetch the JSON:
/redfish/v1/JsonSchemas/ComputerSystem/ComputerSystem.json
- API used to fetch the current policy and to save updated policy:
/redfish/v1/Systems/system/
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I203bd3c5d26071b882cce6b9950cdb3fb1deb212
|
|
- Add sr-only element to icon only buttons
- Removed title from text only buttons
Signed-off-by: Suren Neware <sneware9@in.ibm.com>
Change-Id: Ica57dec70401c04a9d7506306a406fe394e52113
|
|
Passing disabled prop to button and span so file upload button can
visually reflect a disabled form control state.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I78f2db521c4f4016e7e2aa92e5a56bc4f9170fe0
|
|
- Adds download row action in bmc dumps table
- Adds new rowAction download type to support <a> tag with
download attribute
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I97fd70e6a6783d4336ca1a8486cf1cd3062ebb5d
|
|
Both the datepicker and password fields have an assoicated icon. When
the input element receives focus the associated icons are hidden. This
is caused by a z-index issue and was a bug created when fixing another
bug that caused the datepicker icon from rendering above the table
batch actions toolbar.
Both bugs have been resolved with this patchset.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: If923cd5bc6a076b01efa44492f717b78fb6584ca
|
|
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Id46f9f663c456a7d09b55d6d322b00785df4cbe7
|
|
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I00e3fc12a58d644d0aad3c0caf4a94d2ed435109
|
|
The class name showBtn uses a camelCase naming convention and CSS
selector names use the kebab-case naming convention. The z-index
solution is not needed if we hide the element with visibility. Using
both opacity and visibility allows the transition to be elegant.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ie555f958daaadd2bc3a3777b6c2bc7d5e83a0cc5
|