summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorLoic Poulain <loic.poulain@linaro.org>2021-02-26 13:53:02 +0300
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>2021-03-10 17:41:22 +0300
commit0ecc1c70dcd32c0f081b173a1a5d89952686f271 (patch)
tree91685fedc8e3814d4b7033547affc25d42503684 /tools
parent0fccbf0a3b690b162f53b13ed8bc442ea33437dc (diff)
downloadlinux-0ecc1c70dcd32c0f081b173a1a5d89952686f271.tar.xz
bus: mhi: core: Fix invalid error returning in mhi_queue
mhi_queue returns an error when the doorbell is not accessible in the current state. This can happen when the device is in non M0 state, like M3, and needs to be waken-up prior ringing the DB. This case is managed earlier by triggering an asynchronous M3 exit via controller resume/suspend callbacks, that in turn will cause M0 transition and DB update. So, since it's not an error but just delaying of doorbell update, there is no reason to return an error. This also fixes a use after free error for skb case, indeed a caller queuing skb will try to free the skb if the queueing fails, but in that case queueing has been done. Fixes: a8f75cb348fd ("mhi: core: Factorize mhi queuing") Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Link: https://lore.kernel.org/r/1614336782-5809-1-git-send-email-loic.poulain@linaro.org Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions