summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/bpf/prog_tests/cpumask.c
diff options
context:
space:
mode:
authorDavid Vernet <void@manifault.com>2023-03-16 08:40:27 +0300
committerAlexei Starovoitov <ast@kernel.org>2023-03-16 22:28:30 +0300
commit1b403ce77dfbf234723a91bc411dfb03a0499d6e (patch)
tree70cccb7975e4427ef8217c03e426036660e02d09 /tools/testing/selftests/bpf/prog_tests/cpumask.c
parenta5a197df58c44ce32a86b57e970da4bd7b71b399 (diff)
downloadlinux-1b403ce77dfbf234723a91bc411dfb03a0499d6e.tar.xz
bpf: Remove bpf_cpumask_kptr_get() kfunc
Now that struct bpf_cpumask is RCU safe, there's no need for this kfunc. Rather than doing the following: private(MASK) static struct bpf_cpumask __kptr *global; int BPF_PROG(prog, s32 cpu, ...) { struct bpf_cpumask *cpumask; bpf_rcu_read_lock(); cpumask = bpf_cpumask_kptr_get(&global); if (!cpumask) { bpf_rcu_read_unlock(); return -1; } bpf_cpumask_setall(cpumask); ... bpf_cpumask_release(cpumask); bpf_rcu_read_unlock(); } Programs can instead simply do (assume same global cpumask): int BPF_PROG(prog, ...) { struct bpf_cpumask *cpumask; bpf_rcu_read_lock(); cpumask = global; if (!cpumask) { bpf_rcu_read_unlock(); return -1; } bpf_cpumask_setall(cpumask); ... bpf_rcu_read_unlock(); } In other words, no extra atomic acquire / release, and less boilerplate code. This patch removes both the kfunc, as well as its selftests and documentation. Signed-off-by: David Vernet <void@manifault.com> Link: https://lore.kernel.org/r/20230316054028.88924-5-void@manifault.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/cpumask.c')
-rw-r--r--tools/testing/selftests/bpf/prog_tests/cpumask.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/cpumask.c b/tools/testing/selftests/bpf/prog_tests/cpumask.c
index 6c0fe23498c7..cdf4acc18e4c 100644
--- a/tools/testing/selftests/bpf/prog_tests/cpumask.c
+++ b/tools/testing/selftests/bpf/prog_tests/cpumask.c
@@ -16,7 +16,6 @@ static const char * const cpumask_success_testcases[] = {
"test_copy_any_anyand",
"test_insert_leave",
"test_insert_remove_release",
- "test_insert_kptr_get_release",
"test_global_mask_rcu",
};