diff options
| author | Ian Rogers <irogers@google.com> | 2025-01-17 21:18:48 +0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2025-01-18 21:02:10 +0300 |
| commit | 035f0c279bcfc07314240de273d90f4061aef04d (patch) | |
| tree | 28ff6090c9d777f129609c70ab4c9b3ca018f6fc /tools/perf/ui/browsers/annotate.c | |
| parent | ac22d75377a04ceca53a8d438440e82bf4c722fc (diff) | |
| download | linux-035f0c279bcfc07314240de273d90f4061aef04d.tar.xz | |
perf annotate: Prefer passing evsel to evsel->core.idx
An evsel idx may not be stable due to sorting, evlist removal,
etc. Try to reduce it being part of APIs by explicitly passing the
evsel in annotate code. Internally the code just reads evsel->core.idx
so behavior is unchanged.
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Chen Ni <nichen@iscas.ac.cn>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/20250117181848.690474-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
| -rw-r--r-- | tools/perf/ui/browsers/annotate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index d7e727345dab..135d6ce88fb3 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -754,7 +754,7 @@ static int annotate_browser__run(struct annotate_browser *browser, hbt->timer(hbt->arg); if (delay_secs != 0) { - symbol__annotate_decay_histogram(sym, evsel->core.idx); + symbol__annotate_decay_histogram(sym, evsel); hists__scnprintf_title(hists, title, sizeof(title)); annotate_browser__show(&browser->b, title, help); } |