summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2023-01-21 18:54:03 +0300
committerMauro Carvalho Chehab <mchehab@kernel.org>2023-02-08 09:56:05 +0300
commit2e18e118c22594cced8121e6ab7ca27a60bcfc29 (patch)
tree075f6e58ab326395d97ce54298e786307d42dcf1 /tools/perf/scripts/python
parent60ec70a71a9f9975a5d2dd4a7d97c20da0e41976 (diff)
downloadlinux-2e18e118c22594cced8121e6ab7ca27a60bcfc29.tar.xz
media: atomisp: Fix WARN() when the vb2 start_streaming callback fails
The videobuf2-core expects buffers to be put back in the queued state when the vb2 start_streaming callback fails. But the atomisp atomisp_flush_video_pipe() would unconditionally return them to the core in an error state. This triggers the following warning in the videobuf2-core: drivers/media/common/videobuf2/videobuf2-core.c:1652: /* * If done_list is not empty, then start_streaming() didn't call * vb2_buffer_done(vb, VB2_BUF_STATE_QUEUED) but STATE_ERROR or * STATE_DONE. */ WARN_ON(!list_empty(&q->done_list)); Fix this by adding a state argument to atomisp_flush_video_pipe() and use VB2_BUF_STATE_QUEUED as state when atomisp_start_streaming() fails. Reviewed-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions