diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2022-12-29 00:48:15 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-02-08 10:03:07 +0300 |
| commit | 20734fcae96c8e5fd164e7afe40088ffe4e71803 (patch) | |
| tree | 129e54db85b0eff25dfa6f417ae4808cceffac03 /tools/perf/scripts/python/syscall-counts-by-pid.py | |
| parent | 8972ed6ea7a00a39eab8f652e6f2f16a40ed2c3b (diff) | |
| download | linux-20734fcae96c8e5fd164e7afe40088ffe4e71803.tar.xz | |
media: atomisp: Drop atomisp_init_pipe()
atomisp_init_pipe() does 3 things:
1. Init a bunch of list-heads / locks
2. Init the vb_queue for the videodev (aka pipe)
3. zero the per-frame parameters related variables of the pipe
1. and 2. really should not be done at file-open time, but once at probe.
Currently the code is getting away with doing this on every videodev-open
because only 1 open is allowed at a time.
1. is already done at probe time by atomisp_init_subdev_pipe(), move 2. to
atomisp_init_subdev_pipe() so that it is also done once at probe.
As for 3. The per-frame parameters can only be set from a qbuf ioctl,
which can only happen after a reqbufs ioctl and atomisp_buf_cleanup
already zeros the per-frame parameters when the buffers are released,
so 3. is not necessary at all.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions
