diff options
author | Josh Don <joshdon@google.com> | 2023-09-23 02:05:35 +0300 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2023-09-24 13:08:29 +0300 |
commit | 2f8c62296b6f656bbfd17e9f1fadd7478003a9d9 (patch) | |
tree | 0e8239cc8dcdbaf23107992ab5a017e5f0f2af7e /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 30797bce8ef0c73f0c388148ffac92458533b10e (diff) | |
download | linux-2f8c62296b6f656bbfd17e9f1fadd7478003a9d9.tar.xz |
sched/fair: Fix warning in bandwidth distribution
We've observed the following warning being hit in
distribute_cfs_runtime():
SCHED_WARN_ON(cfs_rq->runtime_remaining > 0)
We have the following race:
- CPU 0: running bandwidth distribution (distribute_cfs_runtime).
Inspects the local cfs_rq and makes its runtime_remaining positive.
However, we defer unthrottling the local cfs_rq until after
considering all remote cfs_rq's.
- CPU 1: starts running bandwidth distribution from the slack timer. When
it finds the cfs_rq for CPU 0 on the throttled list, it observers the
that the cfs_rq is throttled, yet is not on the CSD list, and has a
positive runtime_remaining, thus triggering the warning in
distribute_cfs_runtime.
To fix this, we can rework the local unthrottling logic to put the local
cfs_rq on a local list, so that any future bandwidth distributions will
realize that the cfs_rq is about to be unthrottled.
Signed-off-by: Josh Don <joshdon@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230922230535.296350-2-joshdon@google.com
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions