diff options
author | Peter Ujfalusi <peter.ujfalusi@ti.com> | 2019-08-30 13:38:39 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2019-08-30 14:21:20 +0300 |
commit | a2dc6f82fd86fa165222f6062e2478fd122f9f1c (patch) | |
tree | d19ab260e654790aff9b4a031efded45795df1bb /tools/perf/scripts/python/export-to-sqlite.py | |
parent | cc9bbb6cde6c321706f1eff79d077b4a91cd5d12 (diff) | |
download | linux-a2dc6f82fd86fa165222f6062e2478fd122f9f1c.tar.xz |
ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback
Currently the driver uses snd_soc_rtdcom_lookup() in it's mcbsp_start
function to try to stop/restart the DMA as the initial XSYNCERR workaround
need to be done before the DMA is armed.
There are couple of things wrong with this:
- the driver crashes with NULL pointer dereference as the
component->driver->ops is actually NULL
- the driver should not use snd_soc_rtdcom_lookup() in the first place
- Fiddling with DMA is never a good thing
Move the workaround handling to .prepare which is called before the DMA is
armed, so it complies with the requirements.
Reported-by (usage of snd_soc_rtdcom_lookup): Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20190830103841.25128-3-peter.ujfalusi@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions