diff options
author | Matt Roper <matthew.d.roper@intel.com> | 2024-01-30 23:03:09 +0300 |
---|---|---|
committer | Matt Roper <matthew.d.roper@intel.com> | 2024-01-31 19:09:30 +0300 |
commit | 996da37ffa82b9d863f6fe0b7b2ce9d692d0b31e (patch) | |
tree | 40d80f529b1368d5ef7c852419d8e49d1751d12b /tools/perf/scripts/python/export-to-postgresql.py | |
parent | 78366eed6853aa6a5deccb2eb182f9334d2bd208 (diff) | |
download | linux-996da37ffa82b9d863f6fe0b7b2ce9d692d0b31e.tar.xz |
drm/xe: Convert job timeouts from assert to warning
xe_assert() is intended to be used only for "impossible" situations that
should never be hit (and if they are hit it means there's a driver bug
somewhere); assertions are only compiled into debug builds.
Although we expect jobs submitted by the kernel to be well-behaved and
run without error, timeouts are a legitimate possibility for reasons
beyond our control (bad firmware, flaky hardware, etc.). We should use
a real WARN if we encounter these, even for non-debug builds, to ensure
the issue is being properly highlighted in bug reports and such.
Also give the WARNs more human-readable messages and move them below the
general notice-level message that gets printed for any kind of timeout
to make the errors a bit more understandable.
v2:
- Convert the VM / exec_queue_killed assertion as well. (MattB)
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240130200308.1429134-2-matthew.d.roper@intel.com
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions