diff options
| author | Jacob Keller <jacob.e.keller@intel.com> | 2020-09-02 18:53:46 +0300 |
|---|---|---|
| committer | Tony Nguyen <anthony.l.nguyen@intel.com> | 2020-09-25 17:39:24 +0300 |
| commit | 135f4b9e9340dadb78e9737bb4eb9817b9c89dac (patch) | |
| tree | 9ea284ed2431155708a4264dce01a789cfc55361 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | 466e4392920083c58c7ee8905795453d62c4add7 (diff) | |
| download | linux-135f4b9e9340dadb78e9737bb4eb9817b9c89dac.tar.xz | |
ice: fix memory leak if register_netdev_fails
The ice_setup_pf_sw function can cause a memory leak if register_netdev
fails, due to accidentally failing to free the VSI rings. Fix the memory
leak by using ice_vsi_release, ensuring we actually go through the full
teardown process.
This should be safe even if the netdevice is not registered because we
will have set the netdev pointer to NULL, ensuring ice_vsi_release won't
call unregister_netdev.
An alternative fix would be moving management of the PF VSI netdev into
the main VSI setup code. This is complicated and likely requires
significant refactor in how we manage VSIs
Fixes: 3a858ba392c3 ("ice: Add support for VSI allocation and deallocation")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions