diff options
author | Ian Rogers <irogers@google.com> | 2020-10-30 01:37:07 +0300 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2020-11-03 01:33:51 +0300 |
commit | 7a078d2d18801bba7bde7337a823d7342299acf7 (patch) | |
tree | c07d900a1d0fb7c88fdcbf9554083169f53f742d /tools/perf/scripts/python/event_analyzing_sample.py | |
parent | 080b6f40763565f65ebb9540219c71ce885cf568 (diff) | |
download | linux-7a078d2d18801bba7bde7337a823d7342299acf7.tar.xz |
libbpf, hashmap: Fix undefined behavior in hash_bits
If bits is 0, the case when the map is empty, then the >> is the size of
the register which is undefined behavior - on x86 it is the same as a
shift by 0.
Fix by handling the 0 case explicitly and guarding calls to hash_bits for
empty maps in hashmap__for_each_key_entry and hashmap__for_each_entry_safe.
Fixes: e3b924224028 ("libbpf: add resizable non-thread safe internal hashmap")
Suggested-by: Andrii Nakryiko <andriin@fb.com>,
Signed-off-by: Ian Rogers <irogers@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/20201029223707.494059-1-irogers@google.com
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions