diff options
| author | Paul Walmsley <pwalmsley@nvidia.com> | 2013-12-10 06:40:48 +0400 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2013-12-11 00:19:47 +0400 |
| commit | f62438ac53ae852eca8e98a5a96742aac41403c7 (patch) | |
| tree | 88e502b2a8b682d360d745e5b382206adf40f3a8 /sound/spi/at73c213.c | |
| parent | ed326363d7a7844330325148efe06a994e4bc78f (diff) | |
| download | linux-f62438ac53ae852eca8e98a5a96742aac41403c7.tar.xz | |
ALSA: at73c213: clk_round_rate() can return a zero upon error
Treat both negative and zero return values from clk_round_rate()
as errors. This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather
than a signed type, since some clock sources can generate rates higher
than (2^31)-1 Hz.
Eventually, when calling clk_round_rate(), only a return value of
zero will be considered a error. All other values will be
considered valid rates. The comparison against values less than
0 is kept to preserve the correct behavior in the meantime.
Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/spi/at73c213.c')
| -rw-r--r-- | sound/spi/at73c213.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c index 8e3d9a6c7a3b..25c38afaee49 100644 --- a/sound/spi/at73c213.c +++ b/sound/spi/at73c213.c @@ -174,7 +174,7 @@ static int snd_at73c213_set_bitrate(struct snd_at73c213 *chip) dac_rate_new = 8 * (ssc_rate / ssc_div); status = clk_round_rate(chip->board->dac_clk, dac_rate_new); - if (status < 0) + if (status <= 0) return status; /* Ignore difference smaller than 256 Hz. */ |