diff options
author | Roberto Sassu <roberto.sassu@huawei.com> | 2023-07-26 10:39:05 +0300 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2023-07-27 00:07:39 +0300 |
commit | faf302f5a2132960670d085cd44abc30fd60a98d (patch) | |
tree | abadb59a43594b6396f94348a0b6c60a8bbc8b15 /security | |
parent | ca22eca6e2ad7eaed1c791628ef7cb4c739e3da6 (diff) | |
download | linux-faf302f5a2132960670d085cd44abc30fd60a98d.tar.xz |
security: Fix ret values doc for security_inode_init_security()
Commit 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for
inode_init_security hook") unified the !initxattrs and initxattrs cases. By
doing that, security_inode_init_security() cannot return -EOPNOTSUPP
anymore, as it is always replaced with zero at the end of the function.
Also, mentioning -ENOMEM as the only possible error is not correct. For
example, evm_inode_init_security() could return -ENOKEY.
Fix these issues in the documentation of security_inode_init_security().
Fixes: 6bcdfd2cac55 ("security: Allow all LSMs to provide xattrs for inode_init_security hook")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security')
-rw-r--r-- | security/security.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/security.c b/security/security.c index cfdd0cbbcb91..f86567083e66 100644 --- a/security/security.c +++ b/security/security.c @@ -1604,8 +1604,8 @@ EXPORT_SYMBOL(security_dentry_create_files_as); * a security attribute on this particular inode, then it should return * -EOPNOTSUPP to skip this processing. * - * Return: Returns 0 on success, -EOPNOTSUPP if no security attribute is - * needed, or -ENOMEM on memory allocation failure. + * Return: Returns 0 if the LSM successfully initialized all of the inode + * security attributes that are required, negative values otherwise. */ int security_inode_init_security(struct inode *inode, struct inode *dir, const struct qstr *qstr, |