diff options
| author | Mike Marciniszyn <mike.marciniszyn@intel.com> | 2018-11-28 21:32:48 +0300 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@mellanox.com> | 2018-12-07 06:15:36 +0300 |
| commit | 18912c4524385dd6532c682cb9d4f6aa39ba8d47 (patch) | |
| tree | 6f6a9b3d270b88371744cd9a5e57258c732ff64d /samples/trace_events/trace-events-sample.h | |
| parent | 5190f052a3654aa1120ea4f9ff3bfac430459893 (diff) | |
| download | linux-18912c4524385dd6532c682cb9d4f6aa39ba8d47.tar.xz | |
IB/hfi1: Close VNIC sdma_progress sleep window
The call to sdma_progress() is called outside the wait lock.
In this case, there is a race condition where sdma_progress() can return
false and the sdma_engine can idle. If that happens, there will be no
more sdma interrupts to cause the wakeup and the vnic_sdma xmit will hang.
Fix by moving the lock to enclose the sdma_progress() call.
Also, delete the tx_retry. The need for this was removed by:
commit bcad29137a97 ("IB/hfi1: Serve the most starved iowait entry first")
Fixes: 64551ede6cd1 ("IB/hfi1: VNIC SDMA support")
Reviewed-by: Gary Leshner <Gary.S.Leshner@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'samples/trace_events/trace-events-sample.h')
0 files changed, 0 insertions, 0 deletions