diff options
| author | liuyacan <liuyacan@corp.netease.com> | 2022-05-23 07:57:07 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-05-23 11:58:47 +0300 |
| commit | 75c1edf23b95a9c66923d9269d8e86e4dbde151f (patch) | |
| tree | 7af193059b6dde734a092cd48f24ce417f4cd0fc /net | |
| parent | 0a3ad7d323686fbaae8688326cc5ea0d185c6fca (diff) | |
| download | linux-75c1edf23b95a9c66923d9269d8e86e4dbde151f.tar.xz | |
net/smc: postpone sk_refcnt increment in connect()
Same trigger condition as commit 86434744. When setsockopt runs
in parallel to a connect(), and switch the socket into fallback
mode. Then the sk_refcnt is incremented in smc_connect(), but
its state stay in SMC_INIT (NOT SMC_ACTIVE). This cause the
corresponding sk_refcnt decrement in __smc_release() will not be
performed.
Fixes: 86434744fedf ("net/smc: add fallback check to connect()")
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/smc/af_smc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index fce16b9d6e1a..45a24d24210f 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1564,9 +1564,9 @@ static int smc_connect(struct socket *sock, struct sockaddr *addr, if (rc && rc != -EINPROGRESS) goto out; - sock_hold(&smc->sk); /* sock put in passive closing */ if (smc->use_fallback) goto out; + sock_hold(&smc->sk); /* sock put in passive closing */ if (flags & O_NONBLOCK) { if (queue_work(smc_hs_wq, &smc->connect_work)) smc->connect_nonblock = 1; |