diff options
author | Vlad Buslov <vladbu@nvidia.com> | 2023-11-03 18:14:10 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-11-09 04:47:08 +0300 |
commit | 9bc64bd0cd765f696fcd40fc98909b1f7c73b2ba (patch) | |
tree | f5d156a611ce3ee36a7ebc3c934547100634c7a2 /net/ipv4/tcp_scalable.c | |
parent | caf3100810f4150677f4e1057aa0a29f8a2c3743 (diff) | |
download | linux-9bc64bd0cd765f696fcd40fc98909b1f7c73b2ba.tar.xz |
net/sched: act_ct: Always fill offloading tuple iifidx
Referenced commit doesn't always set iifidx when offloading the flow to
hardware. Fix the following cases:
- nf_conn_act_ct_ext_fill() is called before extension is created with
nf_conn_act_ct_ext_add() in tcf_ct_act(). This can cause rule offload with
unspecified iifidx when connection is offloaded after only single
original-direction packet has been processed by tc data path. Always fill
the new nf_conn_act_ct_ext instance after creating it in
nf_conn_act_ct_ext_add().
- Offloading of unidirectional UDP NEW connections is now supported, but ct
flow iifidx field is not updated when connection is promoted to
bidirectional which can result reply-direction iifidx to be zero when
refreshing the connection. Fill in the extension and update flow iifidx
before calling flow_offload_refresh().
Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tuple iifidx")
Reviewed-by: Paul Blakey <paulb@nvidia.com>
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Fixes: 6a9bad0069cf ("net/sched: act_ct: offload UDP NEW connections")
Link: https://lore.kernel.org/r/20231103151410.764271-1-vladbu@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4/tcp_scalable.c')
0 files changed, 0 insertions, 0 deletions