summaryrefslogtreecommitdiff
path: root/net/ipv4/tcp_input.c
diff options
context:
space:
mode:
authorHaiyang Zhang <haiyangz@microsoft.com>2020-02-21 19:32:18 +0300
committerDavid S. Miller <davem@davemloft.net>2020-02-24 03:32:37 +0300
commitf6f13c125e05603f68f5bf31f045b95e6d493598 (patch)
tree3a9bb0f93b7bfa15f5be922144d0bb48968ea475 /net/ipv4/tcp_input.c
parenteae7172f8141eb98e64e6e81acc9e9d5b2add127 (diff)
downloadlinux-f6f13c125e05603f68f5bf31f045b95e6d493598.tar.xz
hv_netvsc: Fix unwanted wakeup in netvsc_attach()
When netvsc_attach() is called by operations like changing MTU, etc., an extra wakeup may happen while netvsc_attach() calling rndis_filter_device_add() which sends rndis messages when queue is stopped in netvsc_detach(). The completion message will wake up queue 0. We can reproduce the issue by changing MTU etc., then the wake_queue counter from "ethtool -S" will increase beyond stop_queue counter: stop_queue: 0 wake_queue: 1 The issue causes queue wake up, and counter increment, no other ill effects in current code. So we didn't see any network problem for now. To fix this, initialize tx_disable to true, and set it to false when the NIC is ready to be attached or registered. Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic") Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
0 files changed, 0 insertions, 0 deletions