diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-05-17 21:56:59 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-05-17 21:56:59 +0400 |
| commit | 372b2312010bece1e36f577d6c99a6193ec54cbd (patch) | |
| tree | b413461c036d301bcd8c558d4f4e1909d4e57a72 /net/core/dev.c | |
| parent | 6f404e441d169afc90929ef5e451ec9779c1f11a (diff) | |
| download | linux-372b2312010bece1e36f577d6c99a6193ec54cbd.tar.xz | |
net: use hlist_del_rcu() in dev_change_name()
Using plain hlist_del() in dev_change_name() is wrong since a
concurrent reader can crash trying to dereference LIST_POISON1.
Bug introduced in commit 72c9528bab94 (net: Introduce
dev_get_by_name_rcu())
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index b624fe4d9bd7..30a4078b3fa2 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1007,7 +1007,7 @@ rollback: } write_lock_bh(&dev_base_lock); - hlist_del(&dev->name_hlist); + hlist_del_rcu(&dev->name_hlist); write_unlock_bh(&dev_base_lock); synchronize_rcu(); |