diff options
| author | Chengfeng Ye <dg573847474@gmail.com> | 2023-06-27 18:24:49 +0300 | 
|---|---|---|
| committer | Corey Minyard <minyard@acm.org> | 2023-07-04 17:22:45 +0300 | 
| commit | b02bb79eee074f07acdfde540f2d4fe2a04471d8 (patch) | |
| tree | baef4e1d99be53c712bb1e95bff08bfb83337656 /lib/timerqueue.c | |
| parent | 6cf1a126de2992b4efe1c3c4d398f8de4aed6e3f (diff) | |
| download | linux-b02bb79eee074f07acdfde540f2d4fe2a04471d8.tar.xz | |
ipmi: fix potential deadlock on &kcs_bmc->lock
As kcs_bmc_handle_event() is executed inside both a timer and a hardirq,
it should disable irq before lock acquisition otherwise deadlock could
happen if the timmer is preemtped by the irq.
Possible deadlock scenario:
aspeed_kcs_check_obe() (timer)
    -> kcs_bmc_handle_event()
    -> spin_lock(&kcs_bmc->lock)
        <irq interruption>
        -> aspeed_kcs_irq()
        -> kcs_bmc_handle_event()
        -> spin_lock(&kcs_bmc->lock) (deadlock here)
This flaw was found using an experimental static analysis tool we are
developing for irq-related deadlock.
The tentative patch fix the potential deadlock by spin_lock_irqsave()
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Message-Id: <20230627152449.36093-1-dg573847474@gmail.com>
Signed-off-by: Corey Minyard <minyard@acm.org>
Diffstat (limited to 'lib/timerqueue.c')
0 files changed, 0 insertions, 0 deletions
