diff options
author | Mike Snitzer <snitzer@redhat.com> | 2015-05-28 22:12:52 +0300 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2015-05-29 18:07:36 +0300 |
commit | e5d8de32cc02a259e1a237ab57cba00f2930fa6a (patch) | |
tree | 5c0230f71e12c9349e9c755f722bf837456b0802 /lib/mpi/mpiutil.c | |
parent | 45714fbed4556149d7f1730f5bae74f81d5e2cd5 (diff) | |
download | linux-e5d8de32cc02a259e1a237ab57cba00f2930fa6a.tar.xz |
dm: fix false warning in free_rq_clone() for unmapped requests
When stacking request-based dm device on non blk-mq device and
device-mapper target could not map the request (error target is used,
multipath target with all paths down, etc), the WARN_ON_ONCE() in
free_rq_clone() will trigger when it shouldn't.
The warning was added by commit aa6df8d ("dm: fix free_rq_clone() NULL
pointer when requeueing unmapped request"). But free_rq_clone() with
clone->q == NULL is valid usage for the case where
dm_kill_unmapped_request() initiates request cleanup.
Fix this false warning by just removing the WARN_ON -- it only generated
false positives and was never useful in catching the intended case
(completing clone request not being mapped e.g. clone->q being NULL).
Fixes: aa6df8d ("dm: fix free_rq_clone() NULL pointer when requeueing unmapped request")
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reported-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions