summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-12-18 20:47:07 +0300
committerDaniel Borkmann <daniel@iogearbox.net>2017-12-19 03:26:04 +0300
commitfa2d41adb953235c4acaa98f6c980fd9eabe0062 (patch)
tree8c8195e18ea84f249167f4d4512fce3cf95680a7 /kernel
parente90004d56bf805db7d4401fe51a80a93c311cfe6 (diff)
downloadlinux-fa2d41adb953235c4acaa98f6c980fd9eabe0062.tar.xz
bpf: make function skip_callee static and return NULL rather than 0
Function skip_callee is local to the source and does not need to be in global scope, so make it static. Also return NULL rather than 0. Cleans up two sparse warnings: symbol 'skip_callee' was not declared. Should it be static? Using plain integer as NULL pointer Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/bpf/verifier.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 56ef21c71bd3..52c9b32d58bf 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -823,6 +823,7 @@ next:
return 0;
}
+static
struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env,
const struct bpf_verifier_state *state,
struct bpf_verifier_state *parent,
@@ -867,7 +868,7 @@ bug:
verbose(env, "verifier bug regno %d tmp %p\n", regno, tmp);
verbose(env, "regno %d parent frame %d current frame %d\n",
regno, parent->curframe, state->curframe);
- return 0;
+ return NULL;
}
static int mark_reg_read(struct bpf_verifier_env *env,