diff options
| author | Peter Hurley <peter@hurleysoftware.com> | 2013-03-12 00:44:41 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-19 03:48:42 +0400 |
| commit | 16759f6cd8c590fa23cb2956fdf32fe23a67e482 (patch) | |
| tree | cfd1c8eb346d6cae8bf82cc2211b21f79b449671 /kernel/debug | |
| parent | ebc9baed42e42f9b51cf61672b7afb72f068d523 (diff) | |
| download | linux-16759f6cd8c590fa23cb2956fdf32fe23a67e482.tar.xz | |
tty: Document unsafe ldisc reference acquire
Merge get_ldisc() into its only call site.
Note how, after merging, the unsafe acquire of an ldisc reference
is obvious.
CPU 0 in tty_ldisc_try() | CPU 1 in tty_ldisc_halt()
|
test_bit(TTY_LDISC, &tty_flags) |
if (true) | clear_bit(TTY_LDISC, &tty_flags)
tty->ldisc != 0? | atomic_read(&tty->ldisc->users)
if (true) | ret_val == 1?
atomic_inc(&tty->ldisc->users) | if (false)
| wait
|
<goes on assuming safe ldisc use> | <doesn't wait - proceeds w/ close>
|
The spin lock in tty_ldisc_try() does nothing wrt synchronizing
the ldisc halt since it's not acquired as part of halting.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/debug')
0 files changed, 0 insertions, 0 deletions