diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2021-01-28 14:41:07 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-01-29 07:36:21 +0300 |
| commit | 80bc97aa0aaab974bbbfb99a78d7515414004616 (patch) | |
| tree | 021fec1df4314cb606ef54de3a24516ca22420b0 /include/net/iucv | |
| parent | ef6af7bdb9e6c14eae8dc5fe852aefe1e089c85c (diff) | |
| download | linux-80bc97aa0aaab974bbbfb99a78d7515414004616.tar.xz | |
net/af_iucv: don't track individual TX skbs for TRANS_HIPER sockets
Stop maintaining the skb_send_q list for TRANS_HIPER sockets.
Not only is it extra overhead, but keeping around a list of skb clones
means that we later also have to match the ->sk_txnotify() calls
against these clones and free them accordingly.
The current matching logic (comparing the skbs' shinfo location) is
frustratingly fragile, and breaks if the skb's head is mangled in any
sort of way while passing from dev_queue_xmit() to the device's
HW queue.
Also adjust the interface for ->sk_txnotify(), to make clear that we
don't actually care about any skb internals.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net/iucv')
| -rw-r--r-- | include/net/iucv/af_iucv.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.h index 0816bcd44dd1..ff06246dbbb9 100644 --- a/include/net/iucv/af_iucv.h +++ b/include/net/iucv/af_iucv.h @@ -133,7 +133,7 @@ struct iucv_sock { atomic_t msg_recv; atomic_t pendings; int transport; - void (*sk_txnotify)(struct sk_buff *skb, + void (*sk_txnotify)(struct sock *sk, enum iucv_tx_notify n); }; |