diff options
| author | Jeff Mahoney <jeffm@suse.com> | 2017-12-04 21:11:45 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-12-07 02:30:29 +0300 |
| commit | e19182c0fff451e3744c1107d98f072e7ca377a0 (patch) | |
| tree | f5bebc158558c68be9852748be356be134f6175d /fs | |
| parent | 692826b2738101549f032a761a9191636e83be4e (diff) | |
| download | linux-e19182c0fff451e3744c1107d98f072e7ca377a0.tar.xz | |
btrfs: fix missing error return in btrfs_drop_snapshot
If btrfs_del_root fails in btrfs_drop_snapshot, we'll pick up the
error but then return 0 anyway due to mixing err and ret.
Fixes: 79787eaab4612 ("btrfs: replace many BUG_ONs with proper error handling")
Cc: <stable@vger.kernel.org> # v3.4+
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/extent-tree.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 784d41e95ed9..16e46ee3cd16 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -9220,6 +9220,7 @@ int btrfs_drop_snapshot(struct btrfs_root *root, ret = btrfs_del_root(trans, fs_info, &root->root_key); if (ret) { btrfs_abort_transaction(trans, ret); + err = ret; goto out_end_trans; } |