diff options
| author | Eric Biggers <ebiggers@google.com> | 2023-10-29 08:03:00 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-10-31 20:38:26 +0300 |
| commit | 783fa2c94f4150fe1b7f7d88b3baf6d98f82b41b (patch) | |
| tree | 5b5229ad9d17c485476139a49f9ea0582143f91e /fs/smb | |
| parent | d328c09ee9f15ee5a26431f5aad7c9239fa85e62 (diff) | |
| download | linux-783fa2c94f4150fe1b7f7d88b3baf6d98f82b41b.tar.xz | |
smb: use crypto_shash_digest() in symlink_hash()
Simplify symlink_hash() by using crypto_shash_digest() instead of an
init+update+final sequence. This should also improve performance.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/smb')
| -rw-r--r-- | fs/smb/client/link.c | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/fs/smb/client/link.c b/fs/smb/client/link.c index c66be4904e1f..a1da50e66fbb 100644 --- a/fs/smb/client/link.c +++ b/fs/smb/client/link.c @@ -42,23 +42,11 @@ symlink_hash(unsigned int link_len, const char *link_str, u8 *md5_hash) rc = cifs_alloc_hash("md5", &md5); if (rc) - goto symlink_hash_err; + return rc; - rc = crypto_shash_init(md5); - if (rc) { - cifs_dbg(VFS, "%s: Could not init md5 shash\n", __func__); - goto symlink_hash_err; - } - rc = crypto_shash_update(md5, link_str, link_len); - if (rc) { - cifs_dbg(VFS, "%s: Could not update with link_str\n", __func__); - goto symlink_hash_err; - } - rc = crypto_shash_final(md5, md5_hash); + rc = crypto_shash_digest(md5, link_str, link_len, md5_hash); if (rc) cifs_dbg(VFS, "%s: Could not generate md5 hash\n", __func__); - -symlink_hash_err: cifs_free_hash(&md5); return rc; } |