diff options
| author | Oleg Drokin <green@linuxhacker.ru> | 2014-02-01 00:41:58 +0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2014-02-01 02:33:13 +0400 |
| commit | d22e6338db7f613dd4f6095c190682fcc519e4b7 (patch) | |
| tree | 6a6ea7ad79a585375b16d1b50bb2236c33a9cf3c /fs/namei.c | |
| parent | b168fff72109a3627686578e31e745f778832f98 (diff) | |
| download | linux-d22e6338db7f613dd4f6095c190682fcc519e4b7.tar.xz | |
Fix mountpoint reference leakage in linkat
Recent changes to retry on ESTALE in linkat
(commit 442e31ca5a49e398351b2954b51f578353fdf210)
introduced a mountpoint reference leak and a small memory
leak in case a filesystem link operation returns ESTALE
which is pretty normal for distributed filesystems like
lustre, nfs and so on.
Free old_path in such a case.
[AV: there was another missing path_put() nearby - on the previous
goto retry]
Signed-off-by: Oleg Drokin: <green@linuxhacker.ru>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/namei.c')
| -rw-r--r-- | fs/namei.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c index 445d9bbc21eb..d580df2e6804 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3926,10 +3926,13 @@ out_dput: done_path_create(&new_path, new_dentry); if (delegated_inode) { error = break_deleg_wait(&delegated_inode); - if (!error) + if (!error) { + path_put(&old_path); goto retry; + } } if (retry_estale(error, how)) { + path_put(&old_path); how |= LOOKUP_REVAL; goto retry; } |