diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2024-11-03 23:20:15 +0300 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2024-11-13 19:46:44 +0300 |
| commit | 6c056ae4b27575d9230b883498d3cd02315ce6cc (patch) | |
| tree | ee250a2c5b52d1a215c0ef495aa30ddb3ce13944 /fs/libfs.c | |
| parent | 95f567f81e43a1bcb5fbf0559e55b7505707300d (diff) | |
| download | linux-6c056ae4b27575d9230b883498d3cd02315ce6cc.tar.xz | |
libfs: kill empty_dir_getattr()
It's used only to initialize ->getattr in one inode_operations instance
(empty_dir_inode_operations) and its behaviour had always been equivalent
to what we get with NULL ->getattr.
Just remove that initializer, along with empty_dir_getattr() itself.
While we are at it, the same instance has ->permission initialized to
generic_permission, which is what NULL ->permission ends up doing.
Again, no point keeping it.
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/libfs.c')
| -rw-r--r-- | fs/libfs.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/fs/libfs.c b/fs/libfs.c index 46966fd8bcf9..12f5185f3fa9 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -1711,15 +1711,6 @@ static struct dentry *empty_dir_lookup(struct inode *dir, struct dentry *dentry, return ERR_PTR(-ENOENT); } -static int empty_dir_getattr(struct mnt_idmap *idmap, - const struct path *path, struct kstat *stat, - u32 request_mask, unsigned int query_flags) -{ - struct inode *inode = d_inode(path->dentry); - generic_fillattr(&nop_mnt_idmap, request_mask, inode, stat); - return 0; -} - static int empty_dir_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr) { @@ -1733,9 +1724,7 @@ static ssize_t empty_dir_listxattr(struct dentry *dentry, char *list, size_t siz static const struct inode_operations empty_dir_inode_operations = { .lookup = empty_dir_lookup, - .permission = generic_permission, .setattr = empty_dir_setattr, - .getattr = empty_dir_getattr, .listxattr = empty_dir_listxattr, }; |