diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2023-03-05 15:04:00 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-03-23 00:38:33 +0300 |
| commit | 2d74ec97131b1179a373b6d521f195c84e894eb6 (patch) | |
| tree | 4d4ba6776a7fdbb08265051fc48206be30fee7c6 /fs/ksmbd | |
| parent | 728f14c72b71a19623df329c1c7c9d1452e56f1e (diff) | |
| download | linux-2d74ec97131b1179a373b6d521f195c84e894eb6.tar.xz | |
ksmbd: add low bound validation to FSCTL_SET_ZERO_DATA
Smatch static checker warning:
fs/ksmbd/smb2pdu.c:7759 smb2_ioctl()
warn: no lower bound on 'off'
Fix unexpected result that could caused from negative off and bfz.
Fixes: b5e5f9dfc915 ("ksmbd: check invalid FileOffset and BeyondFinalZero in FSCTL_ZERO_DATA")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/ksmbd')
| -rw-r--r-- | fs/ksmbd/smb2pdu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c index bc64d36c4dcf..f09afbdde58a 100644 --- a/fs/ksmbd/smb2pdu.c +++ b/fs/ksmbd/smb2pdu.c @@ -7755,7 +7755,7 @@ int smb2_ioctl(struct ksmbd_work *work) off = le64_to_cpu(zero_data->FileOffset); bfz = le64_to_cpu(zero_data->BeyondFinalZero); - if (off > bfz) { + if (off < 0 || bfz < 0 || off > bfz) { ret = -EINVAL; goto out; } |