diff options
author | Eric Biggers <ebiggers@google.com> | 2018-04-19 01:48:42 +0300 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2018-05-03 00:30:57 +0300 |
commit | ab3835aae642a602d98505afbfceb37707bf3ffe (patch) | |
tree | 1d819067e28102d7b61813b055baf69a7a25d6a1 /fs/f2fs/node.c | |
parent | 6dbb17961f46b2eafcea2f2627aabb309553e068 (diff) | |
download | linux-ab3835aae642a602d98505afbfceb37707bf3ffe.tar.xz |
f2fs: call unlock_new_inode() before d_instantiate()
xfstest generic/429 sometimes hangs on f2fs, caused by a thread being
unable to take a directory's i_rwsem for write in vfs_rmdir(). In the
test, one thread repeatedly creates and removes a directory, and other
threads repeatedly look up a file in the directory. The bug is that
f2fs_mkdir() calls d_instantiate() before unlock_new_inode(), resulting
in the directory inode being exposed to lookups before it has been fully
initialized. And with CONFIG_DEBUG_LOCK_ALLOC, unlock_new_inode()
reinitializes ->i_rwsem, corrupting its state when it is already held.
Fix it by calling unlock_new_inode() before d_instantiate(). This
matches what other filesystems do.
Fixes: 57397d86c62d ("f2fs: add inode operations for special inodes")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/node.c')
0 files changed, 0 insertions, 0 deletions