diff options
| author | Lv Ruyi <lv.ruyi@zte.com.cn> | 2022-04-11 06:23:37 +0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-05-13 23:27:24 +0300 |
| commit | 784a09951c1d8383498c0df091a37db612bebfc7 (patch) | |
| tree | 08d4a3e48f2eb2bc7130b18c3f76ccdb5b926c2e /fs/ext4 | |
| parent | af2b327581582a959f1923eca9cafee5b29a7399 (diff) | |
| download | linux-784a09951c1d8383498c0df091a37db612bebfc7.tar.xz | |
ext4: remove unnecessary conditionals
iput() has already handled null and non-null parameter, so it is no
need to use if().
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220411032337.2517465-1-lv.ruyi@zte.com.cn
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/fast_commit.c | 3 | ||||
| -rw-r--r-- | fs/ext4/namei.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 7b0b57be8615..795a60ad1897 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1659,8 +1659,7 @@ static int ext4_fc_replay_create(struct super_block *sb, struct ext4_fc_tl *tl, set_nlink(inode, 1); ext4_mark_inode_dirty(NULL, inode); out: - if (inode) - iput(inode); + iput(inode); return ret; } diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 5675d3b38032..dfe5514035c1 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -3363,8 +3363,7 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir, err = ext4_add_nondir(handle, dentry, &inode); if (handle) ext4_journal_stop(handle); - if (inode) - iput(inode); + iput(inode); goto out_free_encrypted_link; err_drop_inode: |