diff options
| author | Alain Volmat <alain.volmat@foss.st.com> | 2021-02-05 21:59:32 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-02-05 22:17:01 +0300 |
| commit | c64e7efe46b7de21937ef4b3594d9b1fc74f07df (patch) | |
| tree | 82815c835b9b2e083bcd6ff1f34839a24ebc76ae /drivers/spi | |
| parent | e1e2093b16cb1cefe4dc483b00e73d1333260784 (diff) | |
| download | linux-c64e7efe46b7de21937ef4b3594d9b1fc74f07df.tar.xz | |
spi: stm32: make spurious and overrun interrupts visible
We do not expect to receive spurious interrupts so rise a warning
if it happens.
RX overrun is an error condition that signals a corrupted RX
stream both in dma and in irq modes. Report the error and
abort the transfer in either cases.
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Link: https://lore.kernel.org/r/1612551572-495-9-git-send-email-alain.volmat@foss.st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-stm32.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index f3a4ff60ac4b..25c076461011 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -895,8 +895,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) mask |= STM32H7_SPI_SR_RXP; if (!(sr & mask)) { - dev_dbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", - sr, ier); + dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n", + sr, ier); spin_unlock_irqrestore(&spi->lock, flags); return IRQ_NONE; } @@ -923,15 +923,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) } if (sr & STM32H7_SPI_SR_OVR) { - dev_warn(spi->dev, "Overrun: received value discarded\n"); - if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) - stm32h7_spi_read_rxfifo(spi, false); - /* - * If overrun is detected while using DMA, it means that - * something went wrong, so stop the current transfer - */ - if (spi->cur_usedma) - end = true; + dev_err(spi->dev, "Overrun: RX data lost\n"); + end = true; } if (sr & STM32H7_SPI_SR_EOT) { |