diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-12-04 15:29:29 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2023-12-04 17:42:15 +0300 |
| commit | 35ddd61cf023b5deb2b7e9f1627abef053281c0a (patch) | |
| tree | 16c65bfeef8263cf7fb007a1bb07dc9c051cd342 /drivers/platform/x86/x86-android-tablets | |
| parent | 6e79648553818bb21021ccf72ae27f4508844818 (diff) | |
| download | linux-35ddd61cf023b5deb2b7e9f1627abef053281c0a.tar.xz | |
platform/x86: x86-android-tablets: Fix an IS_ERR() vs NULL check in probe
The spi_new_device() function returns NULL on error, it doesn't return
error pointers.
Fixes: 70505ea6de24 ("platform/x86: x86-android-tablets: Add support for SPI device instantiation")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/4b1b2395-c7c5-44a4-b0b0-6d091c7f46a2@moroto.mountain
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/x86-android-tablets')
| -rw-r--r-- | drivers/platform/x86/x86-android-tablets/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c index 6a5975ac3286..f8221a15575b 100644 --- a/drivers/platform/x86/x86-android-tablets/core.c +++ b/drivers/platform/x86/x86-android-tablets/core.c @@ -220,8 +220,8 @@ static __init int x86_instantiate_spi_dev(const struct x86_dev_info *dev_info, i spi_devs[idx] = spi_new_device(controller, &board_info); put_device(&controller->dev); - if (IS_ERR(spi_devs[idx])) - return dev_err_probe(&controller->dev, PTR_ERR(spi_devs[idx]), + if (!spi_devs[idx]) + return dev_err_probe(&controller->dev, -ENOMEM, "creating SPI-device %d\n", idx); return 0; |