diff options
| author | Daniel Golle <daniel@makrotopia.org> | 2024-09-17 16:49:40 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-09-24 11:55:07 +0300 |
| commit | d2b366c43443a21d9bcf047f3ee1f09cf9792dc4 (patch) | |
| tree | 19154a8ce26db281ea3d4239f740dda1fc3716c4 /drivers/net | |
| parent | f011b313e8ebd5b7abd8521b5119aecef403de45 (diff) | |
| download | linux-d2b366c43443a21d9bcf047f3ee1f09cf9792dc4.tar.xz | |
net: phy: aquantia: fix setting active_low bit
phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting
in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit.
Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit.
Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/phy/aquantia/aquantia_leds.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/phy/aquantia/aquantia_leds.c b/drivers/net/phy/aquantia/aquantia_leds.c index 0516ac02c3f8..201c8df93fad 100644 --- a/drivers/net/phy/aquantia/aquantia_leds.c +++ b/drivers/net/phy/aquantia/aquantia_leds.c @@ -120,7 +120,8 @@ int aqr_phy_led_hw_control_set(struct phy_device *phydev, u8 index, int aqr_phy_led_active_low_set(struct phy_device *phydev, int index, bool enable) { return phy_modify_mmd(phydev, MDIO_MMD_VEND1, AQR_LED_DRIVE(index), - VEND1_GLOBAL_LED_DRIVE_VDD, enable); + VEND1_GLOBAL_LED_DRIVE_VDD, + enable ? VEND1_GLOBAL_LED_DRIVE_VDD : 0); } int aqr_phy_led_polarity_set(struct phy_device *phydev, int index, unsigned long modes) |