diff options
| author | Daniel Golle <daniel@makrotopia.org> | 2024-09-17 16:49:55 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-09-24 11:55:07 +0300 |
| commit | 6f9defaf99122d1af9c2562181c77bc99be0672d (patch) | |
| tree | 1e55207b33b541afcde969b49c6a73da163f1c8c /drivers/net/phy/aquantia | |
| parent | d2b366c43443a21d9bcf047f3ee1f09cf9792dc4 (diff) | |
| download | linux-6f9defaf99122d1af9c2562181c77bc99be0672d.tar.xz | |
net: phy: aquantia: fix applying active_low bit after reset
for_each_set_bit was used wrongly in aqr107_config_init() when iterating
over LEDs. Drop misleading 'index' variable and call
aqr_phy_led_active_low_set() for each set bit representing an LED which
is driven by VDD instead of GND pin.
Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/9b1f0cd91f4cda54c8be56b4fe780480baf4aa0f.1726580902.git.daniel@makrotopia.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/phy/aquantia')
| -rw-r--r-- | drivers/net/phy/aquantia/aquantia_main.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index 57b8b8f400fd..4d156d406bab 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -489,7 +489,7 @@ static int aqr107_config_init(struct phy_device *phydev) { struct aqr107_priv *priv = phydev->priv; u32 led_active_low; - int ret, index = 0; + int ret; /* Check that the PHY interface type is compatible */ if (phydev->interface != PHY_INTERFACE_MODE_SGMII && @@ -516,10 +516,9 @@ static int aqr107_config_init(struct phy_device *phydev) /* Restore LED polarity state after reset */ for_each_set_bit(led_active_low, &priv->leds_active_low, AQR_MAX_LEDS) { - ret = aqr_phy_led_active_low_set(phydev, index, led_active_low); + ret = aqr_phy_led_active_low_set(phydev, led_active_low, true); if (ret) return ret; - index++; } return 0; |