summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/sun
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-10-05 16:40:52 +0400
committerDavid S. Miller <davem@davemloft.net>2012-10-07 22:37:12 +0400
commit043c4789726e6abb5be6115cb054af4926481952 (patch)
tree080e6d86f2daac188caf2dbac9230b5f5bf03322 /drivers/net/ethernet/sun
parent97db4b9d02a8fc2f06514f10f6b426b97f6f7a0d (diff)
downloadlinux-043c4789726e6abb5be6115cb054af4926481952.tar.xz
drivers/net/ethernet/renesas/sh_eth.c: fix error return code
The function sh_eth_drv_probe() return 0 for success and negative value for most of its internal tests failures. There is one exception that is error case going to out_release:. For this error case, the function abort its success execution path, but returns non negative value, making it difficult for a caller function to notice the error. This patch fixes the error case that do not return negative value. This was found by Coccinelle, but the code change was made by hand. This patch is not robot generated. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun')
0 files changed, 0 insertions, 0 deletions