diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-07-09 17:24:18 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-07-09 21:01:01 +0300 |
| commit | ad297cd2db8953e2202970e9504cab247b6c7cb4 (patch) | |
| tree | 1ec9fb422276fe114ec28422dad5313fcb9cb93f /drivers/net/ethernet/qualcomm | |
| parent | c78eaeebe855fd93f2e77142ffd0404a54070d84 (diff) | |
| download | linux-ad297cd2db8953e2202970e9504cab247b6c7cb4.tar.xz | |
net: qcom/emac: fix UAF in emac_remove
adpt is netdev private data and it cannot be
used after free_netdev() call. Using adpt after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.
Fixes: 54e19bc74f33 ("net: qcom/emac: do not use devm on internal phy pdev")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qualcomm')
| -rw-r--r-- | drivers/net/ethernet/qualcomm/emac/emac.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 8543bf3c3484..ad655f0a4965 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -735,12 +735,13 @@ static int emac_remove(struct platform_device *pdev) put_device(&adpt->phydev->mdio.dev); mdiobus_unregister(adpt->mii_bus); - free_netdev(netdev); if (adpt->phy.digital) iounmap(adpt->phy.digital); iounmap(adpt->phy.base); + free_netdev(netdev); + return 0; } |