summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2018-04-11 05:08:18 +0300
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2018-04-30 18:12:30 +0300
commit04a1e08cc734da60445c417e314a0f35a642861b (patch)
tree609c9e8729f08f574c35d4b1494953eaf8184fe1 /drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
parent76c2a96d42ca3bdac12c463ff27fec3bb2982e3f (diff)
downloadlinux-04a1e08cc734da60445c417e314a0f35a642861b.tar.xz
i40evf: Replace GFP_ATOMIC with GFP_KERNEL in i40evf_add_vlan
i40evf_add_vlan() is never called in atomic context. i40evf_add_vlan() is only called by i40evf_vlan_rx_add_vid(), which is only set as ".ndo_vlan_rx_add_vid" in struct net_device_ops. ".ndo_vlan_rx_add_vid" is not called in atomic context. Despite never getting called from atomic context, i40evf_add_vlan() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c')
0 files changed, 0 insertions, 0 deletions