diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 11:01:41 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-27 23:45:14 +0300 |
| commit | 89036f233a45d8d17c2de94850bd5e63f185da3d (patch) | |
| tree | bf49c657c4a5a668f2a1a0f92cd6aa7bf1e3f03d /drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | |
| parent | 2bcd619e6e7b992ddaa1caaeafd3eea6990de75c (diff) | |
| download | linux-89036f233a45d8d17c2de94850bd5e63f185da3d.tar.xz | |
net: hisilicon: hns: Replace mdelay() with msleep()
hns_ppe_common_init_hw() and hns_xgmac_init() are never
called in atomic context.
They call mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c index 40711af5bd76..ba4316910dea 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c @@ -215,10 +215,10 @@ static void hns_xgmac_init(void *mac_drv) u32 port = drv->mac_id; dsaf_dev->misc_op->xge_srst(dsaf_dev, port, 0); - mdelay(100); + msleep(100); dsaf_dev->misc_op->xge_srst(dsaf_dev, port, 1); - mdelay(100); + msleep(100); hns_xgmac_lf_rf_control_init(drv); hns_xgmac_exc_irq_en(drv, 0); |