diff options
author | Marc Kleine-Budde <mkl@pengutronix.de> | 2019-12-19 12:17:37 +0300 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2022-02-24 10:26:03 +0300 |
commit | 5b60d334e42a37febfd284bd388e526fcddce02a (patch) | |
tree | 38b2de39ca1fa38fa5f79e1fcc89270f3c561873 /drivers/net/can | |
parent | 181d4447905d551cc664f1e7e796b482c1eec992 (diff) | |
download | linux-5b60d334e42a37febfd284bd388e526fcddce02a.tar.xz |
can: bittiming: can_validate_bitrate(): simplify bit rate checking
This patch simplifies the validation of the fixed bit rates. If a
supported bit rate is found, directly return 0.
If no valid bit rate is found return -EINVAL;
Link: https://lore.kernel.org/all/20220124215642.3474154-6-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can')
-rw-r--r-- | drivers/net/can/dev/bittiming.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/dev/bittiming.c index d5fca3bfaf9a..1b1d1499e2f1 100644 --- a/drivers/net/can/dev/bittiming.c +++ b/drivers/net/can/dev/bittiming.c @@ -248,18 +248,14 @@ can_validate_bitrate(struct net_device *dev, struct can_bittiming *bt, const u32 *bitrate_const, const unsigned int bitrate_const_cnt) { - struct can_priv *priv = netdev_priv(dev); unsigned int i; for (i = 0; i < bitrate_const_cnt; i++) { if (bt->bitrate == bitrate_const[i]) - break; + return 0; } - if (i >= priv->bitrate_const_cnt) - return -EINVAL; - - return 0; + return -EINVAL; } int can_get_bittiming(struct net_device *dev, struct can_bittiming *bt, |