diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-07 12:30:10 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-08-12 13:58:40 +0300 |
| commit | 1314e1220d7d31aa99ed551e42d76ba7be8e5bf4 (patch) | |
| tree | eda4beb65948e8c068e5296e48c2a98aada4e8ee /drivers/misc | |
| parent | fd06978b06a2ad99cb6d048617e50869d4081420 (diff) | |
| download | linux-1314e1220d7d31aa99ed551e42d76ba7be8e5bf4.tar.xz | |
misc: tps6594: Remove redundant dev_err_probe() for platform_get_irq_byname()
There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message
in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230807093010.2112302-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/tps6594-esm.c | 3 | ||||
| -rw-r--r-- | drivers/misc/tps6594-pfsm.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c index a32da1c4ba61..e8d12e7f2d2a 100644 --- a/drivers/misc/tps6594-esm.c +++ b/drivers/misc/tps6594-esm.c @@ -39,8 +39,7 @@ static int tps6594_esm_probe(struct platform_device *pdev) for (i = 0 ; i < pdev->num_resources ; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_esm_isr, IRQF_ONESHOT, diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c index 0e24f8daaa9a..88dcac814892 100644 --- a/drivers/misc/tps6594-pfsm.c +++ b/drivers/misc/tps6594-pfsm.c @@ -266,8 +266,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev) for (i = 0 ; i < pdev->num_resources ; i++) { irq = platform_get_irq_byname(pdev, pdev->resource[i].name); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get %s irq\n", - pdev->resource[i].name); + return irq; ret = devm_request_threaded_irq(dev, irq, NULL, tps6594_pfsm_isr, IRQF_ONESHOT, |