diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2016-02-10 19:58:45 +0300 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2016-02-23 06:34:40 +0300 |
| commit | 21136f89d76dc10d31d294f2bb79c585a039bad6 (patch) | |
| tree | 6d1fe59d7561962f7f661d2cdd0e1e1d9a617347 /drivers/md/dm-service-time.c | |
| parent | 7943bd6dd3e71b9e3679bcd254206d86083e1df2 (diff) | |
| download | linux-21136f89d76dc10d31d294f2bb79c585a039bad6.tar.xz | |
dm mpath: remove repeat_count support from multipath core
Preparation for making __multipath_map() avoid taking the m->lock
spinlock -- in favor of using RCU locking.
repeat_count was primarily for bio-based DM multipath's benefit. There
is really no need for it anymore now that DM multipath is request-based.
As such, repeat_count > 1 is no longer honored and a warning is
displayed if the user attempts to use a value > 1. This is a temporary
change for the round-robin path-selector (as a later commit will restore
its support for repeat_count > 1).
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-service-time.c')
| -rw-r--r-- | drivers/md/dm-service-time.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/md/dm-service-time.c b/drivers/md/dm-service-time.c index 9df8f6bd6418..0370eaf3d949 100644 --- a/drivers/md/dm-service-time.c +++ b/drivers/md/dm-service-time.c @@ -19,7 +19,7 @@ #define ST_MAX_RELATIVE_THROUGHPUT 100 #define ST_MAX_RELATIVE_THROUGHPUT_SHIFT 7 #define ST_MAX_INFLIGHT_SIZE ((size_t)-1 >> ST_MAX_RELATIVE_THROUGHPUT_SHIFT) -#define ST_VERSION "0.2.0" +#define ST_VERSION "0.3.0" struct selector { struct list_head valid_paths; @@ -134,6 +134,11 @@ static int st_add_path(struct path_selector *ps, struct dm_path *path, return -EINVAL; } + if (repeat_count > 1) { + DMWARN_LIMIT("repeat_count > 1 is deprecated, using 1 instead"); + repeat_count = 1; + } + if ((argc == 2) && (sscanf(argv[1], "%u%c", &relative_throughput, &dummy) != 1 || relative_throughput > ST_MAX_RELATIVE_THROUGHPUT)) { |