diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-06-19 03:17:13 +0300 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2019-06-23 09:36:24 +0300 |
commit | 002cdb95dc398919bd37d3228c677a22c5ca1498 (patch) | |
tree | e28c940a9cca62377b533171a2dd30936e8fe79c /drivers/input/joystick/iforce/Makefile | |
parent | 3d4149ec87fdab5006cb94f8ebe4720b1ee7e564 (diff) | |
download | linux-002cdb95dc398919bd37d3228c677a22c5ca1498.tar.xz |
Input: gpio_keys - use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct gpio_keys_drvdata {
...
struct gpio_button_data data[0];
};
size = sizeof(struct gpio_keys_drvdata) + count * sizeof(struct gpio_button_data);
instance = devm_kzalloc(dev, size, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, data, count), GFP_KERNEL);
Notice that, in this case, variable size is not necessary, hence it
is removed.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/joystick/iforce/Makefile')
0 files changed, 0 insertions, 0 deletions