summaryrefslogtreecommitdiff
path: root/drivers/iio/health
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2022-05-14 16:04:32 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2022-06-11 16:35:26 +0300
commit48d1ae774099640a4ee8e96a02b7721b479a7e6f (patch)
treed00161e68dc110f45a52284454e8ac3d5d25d63f /drivers/iio/health
parent7cbb6681d7e5b88688234ad370e027a9346ff7a9 (diff)
downloadlinux-48d1ae774099640a4ee8e96a02b7721b479a7e6f.tar.xz
iio: health: afe4404: Remove duplicated error reporting in .remove()
Returning an error value in an i2c remove callback results in an error message being emitted by the i2c core, but otherwise it doesn't make a difference. As afe4404_remove() already emits an error message on failure and the additional error message by the i2c core doesn't add any useful information, change the return value to zero to suppress this message. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20220514130432.304674-1-u.kleine-koenig@pengutronix.de Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/health')
-rw-r--r--drivers/iio/health/afe4404.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
index aa9311e1e655..1bb7de60f8ca 100644
--- a/drivers/iio/health/afe4404.c
+++ b/drivers/iio/health/afe4404.c
@@ -591,10 +591,8 @@ static int afe4404_remove(struct i2c_client *client)
iio_trigger_unregister(afe->trig);
ret = regulator_disable(afe->regulator);
- if (ret) {
+ if (ret)
dev_err(afe->dev, "Unable to disable regulator\n");
- return ret;
- }
return 0;
}